Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/cache to its recommended version #1937

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Feb 7, 2025

TITLE

Description

There are some versions which will be deprecated (making the ci to fail) soon. This version I've updated to is one of the recommended ones.
See: https://github.com/actions/cache?tab=readme-ov-file#%EF%B8%8F-important-changes

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@FrancoGiachetta FrancoGiachetta added the pipelines This PR/issue is exclusively about improving our CI label Feb 7, 2025
@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review February 7, 2025 15:13
Copy link

github-actions bot commented Feb 7, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     27.450 s ±  0.061 s    [User: 26.653 s, System: 0.795 s]
  Range (min … max):   27.407 s … 27.493 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.432 s ±  0.041 s    [User: 26.603 s, System: 0.828 s]
  Range (min … max):   27.403 s … 27.461 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     15.316 s ±  0.008 s    [User: 26.815 s, System: 0.827 s]
  Range (min … max):   15.310 s … 15.321 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     15.284 s ±  0.048 s    [User: 26.763 s, System: 0.805 s]
  Range (min … max):   15.250 s … 15.318 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.186 s ±  0.255 s    [User: 39.776 s, System: 0.961 s]
  Range (min … max):   11.006 s … 11.367 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.392 s ±  0.122 s    [User: 39.375 s, System: 0.953 s]
  Range (min … max):   11.306 s … 11.478 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.02 ± 0.03 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     11.191 s ±  0.202 s    [User: 39.238 s, System: 0.992 s]
  Range (min … max):   11.048 s … 11.334 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.722 s ±  0.045 s    [User: 39.989 s, System: 0.987 s]
  Range (min … max):   10.690 s … 10.754 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.04 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.627 s ±  0.059 s    [User: 40.390 s, System: 0.986 s]
  Range (min … max):   10.586 s … 10.669 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.986 s ±  0.123 s    [User: 40.365 s, System: 1.027 s]
  Range (min … max):   10.899 s … 11.072 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.03 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     11.037 s ±  0.117 s    [User: 40.399 s, System: 1.131 s]
  Range (min … max):   10.954 s … 11.119 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.850 s ±  0.141 s    [User: 40.538 s, System: 1.146 s]
  Range (min … max):   10.750 s … 10.950 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Feb 7, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.225 ± 0.029 2.196 2.284 1.01 ± 0.02
head big_factorial 2.214 ± 0.017 2.193 2.236 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.174 ± 0.019 2.142 2.202 1.00 ± 0.01
head big_fibonacci 2.169 ± 0.017 2.148 2.196 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.280 ± 0.075 8.090 8.364 1.00
head blake2s_integration_benchmark 8.300 ± 0.116 8.115 8.530 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.293 ± 0.016 2.263 2.311 1.00
head compare_arrays_200000 2.302 ± 0.019 2.280 2.343 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.496 ± 0.009 1.484 1.514 1.00
head dict_integration_benchmark 1.497 ± 0.006 1.488 1.506 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.293 ± 0.013 1.278 1.305 1.00
head field_arithmetic_get_square_benchmark 1.298 ± 0.009 1.277 1.307 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.325 ± 0.104 8.127 8.430 1.00
head integration_builtins 8.356 ± 0.080 8.149 8.422 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.631 ± 0.260 8.414 9.229 1.01 ± 0.03
head keccak_integration_benchmark 8.571 ± 0.083 8.436 8.683 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.280 ± 0.011 2.259 2.295 1.00
head linear_search 2.283 ± 0.017 2.260 2.307 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.565 ± 0.007 1.556 1.577 1.00
head math_cmp_and_pow_integration_benchmark 1.567 ± 0.005 1.562 1.576 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.526 ± 0.014 1.513 1.563 1.00 ± 0.02
head math_integration_benchmark 1.521 ± 0.021 1.508 1.579 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.268 ± 0.010 1.259 1.293 1.00 ± 0.01
head memory_integration_benchmark 1.266 ± 0.005 1.259 1.275 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.652 ± 0.022 1.634 1.712 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.637 ± 0.007 1.630 1.651 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 548.4 ± 1.3 546.8 550.6 1.00 ± 0.00
head pedersen 547.8 ± 1.5 545.5 550.0 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 657.1 ± 2.7 653.9 662.7 1.00
head poseidon_integration_benchmark 658.2 ± 3.9 654.4 665.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.911 ± 0.009 1.896 1.921 1.00
head secp_integration_benchmark 1.915 ± 0.026 1.895 1.986 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 642.3 ± 3.1 639.4 649.5 1.00
head set_integration_benchmark 642.9 ± 2.2 640.0 647.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.505 ± 0.050 4.450 4.595 1.00
head uint256_integration_benchmark 4.526 ± 0.033 4.464 4.559 1.00 ± 0.01

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (7a97bed) to head (53257ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1937   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         102      102           
  Lines       41566    41566           
=======================================
  Hits        40068    40068           
  Misses       1498     1498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants