Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some warnings #1980

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed some warnings #1980

wants to merge 1 commit into from

Conversation

yuvalsw
Copy link
Collaborator

@yuvalsw yuvalsw commented Feb 27, 2025

TITLE

Fixed some warnings

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

Copy link

github-actions bot commented Feb 27, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     27.179 s ±  0.015 s    [User: 26.404 s, System: 0.773 s]
  Range (min … max):   27.169 s … 27.189 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.156 s ±  0.028 s    [User: 26.422 s, System: 0.732 s]
  Range (min … max):   27.137 s … 27.176 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.976 s ±  0.022 s    [User: 26.414 s, System: 0.782 s]
  Range (min … max):   14.960 s … 14.992 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.947 s ±  0.002 s    [User: 26.351 s, System: 0.784 s]
  Range (min … max):   14.945 s … 14.948 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.300 s ±  0.039 s    [User: 38.815 s, System: 0.926 s]
  Range (min … max):   11.273 s … 11.327 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.096 s ±  0.255 s    [User: 38.908 s, System: 0.907 s]
  Range (min … max):   10.915 s … 11.276 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.837 s ±  0.238 s    [User: 39.361 s, System: 0.938 s]
  Range (min … max):   10.668 s … 11.005 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.857 s ±  0.068 s    [User: 39.442 s, System: 0.930 s]
  Range (min … max):   10.809 s … 10.905 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.00 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.704 s ±  0.159 s    [User: 40.044 s, System: 0.939 s]
  Range (min … max):   10.591 s … 10.817 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.822 s ±  0.033 s    [User: 39.821 s, System: 0.916 s]
  Range (min … max):   10.799 s … 10.845 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.763 s ±  0.172 s    [User: 40.046 s, System: 1.047 s]
  Range (min … max):   10.642 s … 10.885 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.541 s ±  0.058 s    [User: 40.091 s, System: 1.019 s]
  Range (min … max):   10.500 s … 10.582 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Feb 27, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.189 ± 0.018 2.173 2.230 1.00
head big_factorial 2.190 ± 0.017 2.172 2.217 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.116 ± 0.018 2.100 2.146 1.00
head big_fibonacci 2.119 ± 0.016 2.099 2.141 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.866 ± 0.127 7.775 8.172 1.00 ± 0.02
head blake2s_integration_benchmark 7.857 ± 0.083 7.764 7.991 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.279 ± 0.033 2.237 2.329 1.01 ± 0.02
head compare_arrays_200000 2.266 ± 0.020 2.229 2.292 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.494 ± 0.015 1.478 1.519 1.00
head dict_integration_benchmark 1.499 ± 0.007 1.488 1.512 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.262 ± 0.011 1.248 1.281 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.258 ± 0.014 1.245 1.293 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.915 ± 0.054 7.858 8.014 1.00
head integration_builtins 7.921 ± 0.068 7.822 8.030 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.135 ± 0.092 8.060 8.302 1.00
head keccak_integration_benchmark 8.164 ± 0.084 8.073 8.285 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.248 ± 0.020 2.218 2.277 1.00
head linear_search 2.274 ± 0.037 2.236 2.335 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.584 ± 0.016 1.570 1.624 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.579 ± 0.016 1.565 1.616 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.526 ± 0.006 1.514 1.533 1.00
head math_integration_benchmark 1.542 ± 0.026 1.518 1.607 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.266 ± 0.016 1.252 1.306 1.00 ± 0.02
head memory_integration_benchmark 1.265 ± 0.012 1.251 1.290 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.633 ± 0.007 1.622 1.642 1.00
head operations_with_data_structures_benchmarks 1.645 ± 0.022 1.628 1.699 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 543.6 ± 2.5 540.5 549.3 1.00
head pedersen 545.1 ± 2.1 542.3 548.0 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 664.9 ± 9.0 650.5 673.6 1.00
head poseidon_integration_benchmark 669.0 ± 10.7 658.5 696.2 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.924 ± 0.022 1.903 1.970 1.01 ± 0.01
head secp_integration_benchmark 1.910 ± 0.007 1.902 1.926 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 684.0 ± 4.2 678.8 689.5 1.00
head set_integration_benchmark 687.4 ± 3.2 682.5 691.5 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.398 ± 0.032 4.348 4.435 1.00
head uint256_integration_benchmark 4.436 ± 0.058 4.365 4.542 1.01 ± 0.01

@yuvalsw yuvalsw force-pushed the yuval/fix_warnings branch from f3f332b to a81a45c Compare March 2, 2025 12:34
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (3de653d) to head (441cc4e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   96.46%   96.46%   -0.01%     
==========================================
  Files         103      103              
  Lines       42512    42510       -2     
==========================================
- Hits        41010    41008       -2     
  Misses       1502     1502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, and @pefontana)


CHANGELOG.md line 9 at r1 (raw file):

#### [2.0.0] - 2025-02-26

- fix: Check overflow in cairo pie address calculation [#1945](https://github.com/lambdaclass/cairo-vm/pull/1945)

why all these changes in the CHANGELOG doc. is this intentional?

Copy link
Collaborator

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, and @pefontana)

Copy link
Collaborator Author

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, and @pefontana)

@yuvalsw yuvalsw force-pushed the yuval/fix_warnings branch from a81a45c to 441cc4e Compare March 2, 2025 14:00
Copy link
Collaborator Author

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, and @pefontana)


CHANGELOG.md line 9 at r1 (raw file):

Previously, OmriEshhar1 wrote…

why all these changes in the CHANGELOG doc. is this intentional?

No, probably some auto format. Thanks.

@yuvalsw yuvalsw enabled auto-merge March 2, 2025 14:01
Copy link
Collaborator

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, and @pefontana)

Copy link
Collaborator

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, and @pefontana)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants