Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

levm(ci): order forks chronologically #1945

Merged
merged 9 commits into from
Feb 14, 2025
Merged

levm(ci): order forks chronologically #1945

merged 9 commits into from
Feb 14, 2025

Conversation

lima-limon-inc
Copy link
Contributor

@lima-limon-inc lima-limon-inc commented Feb 13, 2025

Motivation

When the EF tests run, they were outputted at an arbitrary order. It would be better if they were ordered chronologically.

Description

Changes report.rs, in order for the tests results in the shell to be shown chronologically.

@lima-limon-inc lima-limon-inc requested a review from a team as a code owner February 13, 2025 20:32
@lima-limon-inc lima-limon-inc marked this pull request as draft February 13, 2025 20:32
Copy link

github-actions bot commented Feb 13, 2025

Total lines added: 0
Total lines removed: 0
Total lines changed: 0

@lima-limon-inc lima-limon-inc self-assigned this Feb 13, 2025
@lima-limon-inc lima-limon-inc changed the title Order forks chronologically levm(ci): order forks chronologically Feb 13, 2025
@lambdaclass lambdaclass deleted a comment from github-actions bot Feb 13, 2025
Copy link

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 239.3 ± 5.3 237.0 254.2 1.00
levm_Factorial 912.0 ± 8.2 902.1 925.9 3.81 ± 0.09

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.459 ± 0.104 1.345 1.636 1.00
levm_FactorialRecursive 15.762 ± 0.038 15.716 15.830 10.80 ± 0.77

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 213.7 ± 11.4 208.4 246.1 1.00
levm_Fibonacci 905.3 ± 13.9 892.4 934.8 4.24 ± 0.24

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.8 ± 0.2 8.6 9.2 1.00
levm_ManyHashes 18.3 ± 0.5 17.9 19.8 2.08 ± 0.07

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.243 ± 0.014 3.230 3.277 1.00
levm_BubbleSort 6.172 ± 0.106 6.093 6.448 1.90 ± 0.03

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 251.9 ± 3.9 247.7 259.7 1.00
levm_ERC20Transfer 544.3 ± 3.3 539.3 548.8 2.16 ± 0.04

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 141.3 ± 0.6 140.5 142.3 1.00
levm_ERC20Mint 356.2 ± 6.1 352.4 372.6 2.52 ± 0.04

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.040 ± 0.005 1.033 1.049 1.00
levm_ERC20Approval 2.035 ± 0.023 2.013 2.096 1.96 ± 0.02

Main Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 238.3 ± 3.7 236.1 248.7 1.00
levm_Factorial 905.1 ± 6.7 896.6 918.3 3.80 ± 0.07

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.485 ± 0.086 1.347 1.579 1.00
levm_FactorialRecursive 15.655 ± 0.024 15.625 15.702 10.54 ± 0.61

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 209.6 ± 1.3 207.3 212.3 1.00
levm_Fibonacci 909.5 ± 14.3 892.7 927.7 4.34 ± 0.07

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.1 8.7 8.9 1.00
levm_ManyHashes 18.4 ± 0.3 18.1 18.9 2.10 ± 0.03

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.274 ± 0.019 3.250 3.300 1.00
levm_BubbleSort 6.108 ± 0.048 6.055 6.186 1.87 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 250.3 ± 3.2 247.9 258.4 1.00
levm_ERC20Transfer 543.0 ± 7.7 537.0 563.9 2.17 ± 0.04

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 141.3 ± 1.1 139.5 142.9 1.00
levm_ERC20Mint 353.2 ± 2.9 350.0 358.6 2.50 ± 0.03

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.045 ± 0.007 1.034 1.056 1.00
levm_ERC20Approval 2.042 ± 0.017 2.015 2.078 1.95 ± 0.02

@lima-limon-inc lima-limon-inc marked this pull request as ready for review February 13, 2025 20:46
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo 👍

I'm annoying, I know

lima-limon-inc and others added 2 commits February 14, 2025 09:12
Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
@lima-limon-inc
Copy link
Contributor Author

fix typo 👍

I'm annoying, I know

Hi Jere!! Please, don't be ridiculous! You are not annoying at all!

It's so nice to see you around here again ^_^

@fborello-lambda fborello-lambda added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 1e05911 Feb 14, 2025
22 checks passed
@fborello-lambda fborello-lambda deleted the levm/ci/fix branch February 14, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants