feat(l1, l2): show rich wallets on startup #2045
Open
+117
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomip01
changed the title
mpaulucci
reviewed
Feb 21, 2025
cmd/ethrex/ethrex.rs
Outdated
| @@ -174,6 +177,23 @@ async fn main() { | |||
| }; | |||
|
|
|||
| let genesis = read_genesis_file(&network); | |||
|
|
|||
| // Show top rich accounts | |||
There was a problem hiding this comment.
We don't want this when running an L1 node. This seems for testing purposed, dunno why this is here.
There was a problem hiding this comment.
I move it to only print the accounts if we are in dev_mode for the L1.
tomip01
commented
Feb 21, 2025
Comment on lines
+302
to
+303
| let l2_pks = include_str!("../../test_data/private_keys.txt"); | ||
| show_rich_accounts(&genesis, l2_pks); |
There was a problem hiding this comment.
I use this so we can run the print independent where we execute it
tomip01
commented
Feb 21, 2025
Comment on lines
+527
to
+529
| let Ok(pk_h256) = pk_str.parse::<H256>() else { | ||
| return; | ||
| }; |
There was a problem hiding this comment.
If there is any error, don't print the addresses so we don't stop the ethrex client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In this PR we show the top 10 rich accounts on startup. Also, we add to the cli and option to parse a private key to an address.
Description
ethrex_l2cli we add theutilssubcommand to calculate the address from the private key.The print of the addresses set in the genesis block is show this way:
Closes #1981
Links to #2034