Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transition constraints #721

Merged
merged 93 commits into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
5329135
Start refactor
entropidelic Dec 14, 2023
9219428
Add TransitionZerofiersIter and implement Iterator trait
entropidelic Dec 15, 2023
3b97382
Stark prover code compiling
entropidelic Dec 15, 2023
00f7fb1
Save progress
entropidelic Dec 15, 2023
2572ae6
Refactor is compiling
entropidelic Dec 18, 2023
c33f548
Comment code to run only fibonacci AIR tests
entropidelic Dec 18, 2023
368ee81
Change compute_transition function
entropidelic Dec 19, 2023
12d7894
Code is compiling
entropidelic Dec 19, 2023
cc3a058
Add some debug prints
entropidelic Dec 19, 2023
216fc00
Dummy commit
entropidelic Dec 19, 2023
ff2d52a
Dummy commit
entropidelic Dec 19, 2023
17e0b2d
Dummy commit
entropidelic Dec 19, 2023
a95fe56
Fix zerofier evaluations bugs and make fibonacci AIR test pass
entropidelic Dec 19, 2023
dae0093
Remove commented code
entropidelic Dec 20, 2023
ae504be
Implement bit flags AIR and test
entropidelic Dec 20, 2023
725e276
Add bit flag AIR example file
entropidelic Dec 20, 2023
50098fb
Fix get_trace_evaluations function for multi-row step AIRs
entropidelic Dec 21, 2023
db071c1
Save debugging process
entropidelic Dec 23, 2023
edb653d
Refactor step view functionality
entropidelic Jan 4, 2024
8c09d43
Save work in progress
entropidelic Jan 4, 2024
5d98b39
Bugs fixed and bit flags AIR integration test pussing
entropidelic Jan 4, 2024
b11cffb
Remove unused code
entropidelic Jan 4, 2024
d30a25b
Fix fibonacci 2 cols to new constraints design
entropidelic Jan 5, 2024
ee73a6e
Fix quadratic AIRs to new constraints design
entropidelic Jan 5, 2024
9fea590
Fix fibonacci RAP AIR
entropidelic Jan 5, 2024
aa92bf1
Fix shifted 2 columns fibonacci AIR to new constraints design
entropidelic Jan 5, 2024
eb45666
Fix dummy AIR to new constraints design
entropidelic Jan 5, 2024
324bd3b
Remove unused code and fix winterfell adapter version of lambdaworks …
entropidelic Jan 5, 2024
4411e50
Implement some Cairo constraints with the new constraints model
entropidelic Jan 8, 2024
ad8d5b4
Add some more constraints
entropidelic Jan 8, 2024
0503bab
Finish operand constraints
entropidelic Jan 8, 2024
922561b
Add some more constraints
entropidelic Jan 9, 2024
03db5e2
Finish porting all constraints
entropidelic Jan 9, 2024
f647d2e
Make Cairo prover compile
entropidelic Jan 9, 2024
9073632
Make Cairo prover compile
entropidelic Jan 9, 2024
3ed7785
Cairo tests running but not passing with some constraints enabled
entropidelic Jan 9, 2024
90dbe7a
Make zerofier evaluations independent of constraint index in constrai…
entropidelic Jan 10, 2024
c098339
Remove unused code
entropidelic Jan 10, 2024
ed2e117
Remove more unused code
entropidelic Jan 10, 2024
6e82f4f
Rollback change in exercises file
entropidelic Jan 10, 2024
2ccbae8
Uncomment winterfell adapter
entropidelic Jan 10, 2024
b87dca0
Update winterfell adapter AI
entropidelic Jan 10, 2024
19e5531
Update winterfell adapter example
entropidelic Jan 10, 2024
967161a
Fix TOML
entropidelic Jan 10, 2024
662d5d3
Save changes in winterfell adapter
entropidelic Jan 10, 2024
bc2c6c6
Save changes in winterfell adapter
entropidelic Jan 10, 2024
ae5ee5c
Fix TOML
entropidelic Jan 10, 2024
042be77
Fix winterfell adapter crate
entropidelic Jan 10, 2024
80ea80c
Minor fix
entropidelic Jan 10, 2024
4c450fa
Save work in progress
entropidelic Jan 11, 2024
7ba0deb
Save work in progress - code compiling, fibonacci test failing
entropidelic Jan 11, 2024
1fab5a9
Fix some bugs
entropidelic Jan 12, 2024
4479345
Make 2 columns fibonacci test pass
entropidelic Jan 12, 2024
fe69691
Make 2 columns shifted fibonacci test pass
entropidelic Jan 12, 2024
abec134
Save work in progress
entropidelic Jan 15, 2024
33b9be0
Fix bug and make bit flags AIR test pass
entropidelic Jan 15, 2024
2365559
Make quadratic AIR test pass
entropidelic Jan 15, 2024
bb6c0ee
Fix dummy AIR test
entropidelic Jan 15, 2024
044df29
Save work in progress
entropidelic Jan 15, 2024
dd89c08
Fix some bugs
entropidelic Jan 15, 2024
e751cd1
Fix some more bugs
entropidelic Jan 15, 2024
87e43c2
Fix some more bugs
entropidelic Jan 15, 2024
aa95b45
Fix some more bugs
entropidelic Jan 15, 2024
1843be6
Make Cairo tests pass
entropidelic Jan 15, 2024
4143cad
Remove commented code
entropidelic Jan 16, 2024
c8f5333
Merge branch 'main' into constraints-refactor
entropidelic Jan 16, 2024
3065df5
Merge branch 'main' into constraints-refactor
entropidelic Jan 16, 2024
ee457c3
Merge remote-tracking branch 'origin/constraints-refactor' into const…
entropidelic Jan 16, 2024
f0f473e
Pin winterfell adapter and miden example to version of lambdaworks
entropidelic Jan 16, 2024
b7c46c6
Polish code
entropidelic Jan 16, 2024
5bddb6c
Polish more code
entropidelic Jan 16, 2024
a747a89
Fix periodic columns AIR example and tests
entropidelic Jan 16, 2024
d2b86d5
Remove some useless code
entropidelic Jan 16, 2024
1480306
Fix some clippy warnings
entropidelic Jan 16, 2024
fd0a46b
Apply clippy fix
entropidelic Jan 16, 2024
94c25b6
Rearrange debug code in Cairo AIR
entropidelic Jan 16, 2024
5b9aa42
Fix wasm test
entropidelic Jan 16, 2024
48d6403
Import module inside debug scope
entropidelic Jan 16, 2024
890889b
Fix code
entropidelic Jan 16, 2024
f96dfb7
Fix lint
entropidelic Jan 16, 2024
8ee97b2
Remove useless comments
entropidelic Jan 16, 2024
4233aea
Add some docs for transition constraints trait
entropidelic Jan 16, 2024
f95de6c
Polish docs a bit
entropidelic Jan 16, 2024
faa67df
Add more comments to code
entropidelic Jan 17, 2024
74950fc
Remove unused code
entropidelic Jan 17, 2024
90f55cf
Apply optimization
entropidelic Jan 17, 2024
eb6383f
Remove unused code
entropidelic Jan 17, 2024
62aee83
Add some comments
entropidelic Jan 17, 2024
4d88a50
Add type alias for ZerofierGroupKey
entropidelic Jan 17, 2024
7e4745a
Add instruments, use iterators in last eval loop
MauroToscano Jan 19, 2024
0b3cd4b
Fmt
MauroToscano Jan 19, 2024
c5542f7
Merge branch 'main' into constraints-refactor
MauroToscano Jan 19, 2024
c79db0f
Constraint refactor parallel (#773)
MauroToscano Jan 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ lambdaworks-math = { path = "./math", version = "0.5.0", default-features = fals
stark-platinum-prover = { path = "./provers/stark" }
cairo-platinum-prover = { path = "./provers/cairo" }
lambdaworks-winterfell-adapter = { path = "./winterfell_adapter"}

[patch.crates-io]
winter-air = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
winter-prover = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ clippy:
cargo clippy --workspace --all-targets -- -D warnings
cargo clippy --workspace --all-targets --features wasm -- -D warnings
cargo clippy --workspace --all-targets --features cli -- -D warnings
cargo clippy --workspace --all-targets --features parallel -- -D warnings
cargo clippy --tests

clippy-cuda:
Expand Down
2 changes: 1 addition & 1 deletion examples/prove-miden/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ path = "src/main.rs"
lambdaworks-crypto = { workspace = true }
lambdaworks-math = { workspace = true, features = ["lambdaworks-serde-string"] }
lambdaworks-winterfell-adapter = { workspace = true }
stark-platinum-prover = { workspace = true, features = ["instruments", "parallel"] }
stark-platinum-prover = { git = "https://github.com/lambdaclass/lambdaworks" , rev = "3da725de1e6f76c04ddbb3ccb67e6038a7663134", features = ["winter_compatibility"] }

serde = { version = "1.0" }
serde_json = "1"
Expand Down
Binary file added provers/cairo/proof.proof
Binary file not shown.
Loading