Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(README): Finish Feature chart #756

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

PatStiles
Copy link
Collaborator

Finish Feature Chart

Description

Finish filling out chart comparing lambdaworks to other cryptography libraries.

Type of change

Please delete options that are not relevant.

  • New feature

@PatStiles PatStiles requested a review from a team as a code owner January 11, 2024 01:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1acc827) 95.36% compared to head (51ee013) 95.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         140      140           
  Lines       31393    31393           
=======================================
  Hits        29938    29938           
  Misses       1455     1455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

diegokingston
diegokingston previously approved these changes Jan 11, 2024
MauroToscano
MauroToscano previously approved these changes Jan 11, 2024
@MauroToscano
Copy link
Collaborator

I didn't want to heavy check mark the small fields since we didn't implement the full extensions, but it's not very relevant either way

@diegokingston diegokingston dismissed stale reviews from MauroToscano and themself via 51ee013 January 11, 2024 17:08
@MauroToscano MauroToscano added this pull request to the merge queue Jan 11, 2024
Merged via the queue into lambdaclass:main with commit a5baee5 Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants