🚸 Do not validate twice within Artifact.from_X(...) when passing schema (#2765)

Author: falexwolf

lamindb/curators/core.py

@@ -305,6 +305,8 @@ def validate(self) -> None:
         for slot, curator in self._slots.items():
             logger.info(f"validating slot {slot} ...")
             curator.validate()
+        # set _is_validated to True as no slot raised an error
+        self._is_validated = True
 
     @doc_args(SAVE_ARTIFACT_DOCSTRING)
     def save_artifact(

tests/curators/test_curators_examples.py

@@ -427,7 +427,10 @@ def test_anndata_curator_different_components(small_dataset1_schema: ln.Schema):
             assert isinstance(curator.slots["uns"], ln.curators.DataFrameCurator)
         artifact = ln.Artifact.from_anndata(
             adata, key="examples/dataset1.h5ad", schema=anndata_schema
-        ).save()
+        )
+        assert artifact._curator._is_validated  # important test, do not remove
+        artifact.save()
+        assert not hasattr(artifact, "_curator")  # test that curator is deleted
         assert artifact.schema == anndata_schema
         assert artifact.features.slots["var.T"].n == 3  # 3 genes get linked
         if add_comp == "obs":