Skip to content

Commit 33cf81a

Browse files
committed
Changes following review
1 parent 8624303 commit 33cf81a

File tree

1 file changed

+8
-5
lines changed
  • libs/core/langchain_core/output_parsers

1 file changed

+8
-5
lines changed

libs/core/langchain_core/output_parsers/list.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,21 @@
2020
T = TypeVar("T")
2121

2222

23-
def _droplastn(iterator: Iterator[T], n: int) -> Iterator[T]:
23+
def droplastn(
24+
iter: Iterator[T], # noqa: A002
25+
n: int,
26+
) -> Iterator[T]:
2427
"""Drop the last n elements of an iterator.
2528
2629
Args:
27-
iterator: The iterator to drop elements from.
30+
iter: The iterator to drop elements from.
2831
n: The number of elements to drop.
2932
3033
Yields:
3134
The elements of the iterator, except the last n elements.
3235
"""
3336
buffer: deque[T] = deque()
34-
for item in iterator:
37+
for item in iter:
3538
buffer.append(item)
3639
if len(buffer) > n:
3740
yield buffer.popleft()
@@ -85,7 +88,7 @@ def _transform(
8588
try:
8689
done_idx = 0
8790
# yield only complete parts
88-
for m in _droplastn(self.parse_iter(buffer), 1):
91+
for m in droplastn(self.parse_iter(buffer), 1):
8992
done_idx = m.end()
9093
yield [m.group(1)]
9194
buffer = buffer[done_idx:]
@@ -119,7 +122,7 @@ async def _atransform(
119122
try:
120123
done_idx = 0
121124
# yield only complete parts
122-
for m in _droplastn(self.parse_iter(buffer), 1):
125+
for m in droplastn(self.parse_iter(buffer), 1):
123126
done_idx = m.end()
124127
yield [m.group(1)]
125128
buffer = buffer[done_idx:]

0 commit comments

Comments
 (0)