core: Add ruff rules for Pylint PLC (Convention) and PLE (Errors) (#29286)

See https://docs.astral.sh/ruff/rules/#pylint-pl

Author: cbornet

libs/core/langchain_core/callbacks/manager.py

@@ -2244,9 +2244,6 @@ async def on_chain_error(
 T = TypeVar("T", CallbackManager, AsyncCallbackManager)
 
 
-H = TypeVar("H", bound=BaseCallbackHandler, covariant=True)
-
-
 def _configure(
     callback_manager_cls: type[T],
     inheritable_callbacks: Callbacks = None,

libs/core/langchain_core/document_loaders/blob_loaders.py

@@ -11,8 +11,7 @@
 from typing import TYPE_CHECKING
 
 # Re-export Blob and PathLike for backwards compatibility
-from langchain_core.documents.base import Blob as Blob
-from langchain_core.documents.base import PathLike as PathLike
+from langchain_core.documents.base import Blob, PathLike
 
 if TYPE_CHECKING:
     from collections.abc import Iterable

libs/core/langchain_core/messages/modifier.py

@@ -25,7 +25,7 @@ def __init__(self, id: str, **kwargs: Any) -> None:
             msg = "RemoveMessage does not support 'content' field."
             raise ValueError(msg)
 
-        return super().__init__("", id=id, **kwargs)
+        super().__init__("", id=id, **kwargs)
 
 
 RemoveMessage.model_rebuild()

libs/core/langchain_core/output_parsers/list.py

@@ -8,7 +8,6 @@
 from collections import deque
 from io import StringIO
 from typing import TYPE_CHECKING, TypeVar, Union
-from typing import Optional as Optional
 
 from typing_extensions import override
 

libs/core/langchain_core/output_parsers/string.py

@@ -1,7 +1,5 @@
 """String output parser."""
 
-from typing import Optional as Optional
-
 from langchain_core.output_parsers.transform import BaseTransformOutputParser
 
 

libs/core/langchain_core/prompts/pipeline.py

@@ -1,7 +1,6 @@
 """[DEPRECATED] Pipeline prompt template."""
 
 from typing import Any
-from typing import Optional as Optional
 
 from pydantic import model_validator
 

libs/core/langchain_core/runnables/configurable.py

@@ -5,8 +5,12 @@
 import enum
 import threading
 from abc import abstractmethod
-from collections.abc import AsyncIterator, Iterator, Sequence
-from collections.abc import Mapping as Mapping
+from collections.abc import (
+    AsyncIterator,
+    Iterator,
+    Mapping,  # noqa: F401 Needed by pydantic
+    Sequence,
+)
 from functools import wraps
 from typing import (
     TYPE_CHECKING,

libs/core/langchain_core/runnables/graph_mermaid.py

@@ -195,13 +195,13 @@ def add_subgraph(edges: list[Edge], prefix: str) -> None:
             )
 
         # Recursively add nested subgraphs
-        for nested_prefix in edge_groups:
+        for nested_prefix, edges_ in edge_groups.items():
             if not nested_prefix.startswith(prefix + ":") or nested_prefix == prefix:
                 continue
             # only go to first level subgraphs
             if ":" in nested_prefix[len(prefix) + 1 :]:
                 continue
-            add_subgraph(edge_groups[nested_prefix], nested_prefix)
+            add_subgraph(edges_, nested_prefix)
 
         if prefix and not self_loop:
             mermaid_graph += "\tend\n"
@@ -210,20 +210,20 @@ def add_subgraph(edges: list[Edge], prefix: str) -> None:
     add_subgraph(edge_groups.get("", []), "")
 
     # Add remaining subgraphs with edges
-    for prefix in edge_groups:
+    for prefix, edges_ in edge_groups.items():
         if ":" in prefix or prefix == "":
             continue
-        add_subgraph(edge_groups[prefix], prefix)
+        add_subgraph(edges_, prefix)
         seen_subgraphs.add(prefix)
 
     # Add empty subgraphs (subgraphs with no internal edges)
     if with_styles:
-        for prefix in subgraph_nodes:
+        for prefix, subgraph_node in subgraph_nodes.items():
             if ":" not in prefix and prefix not in seen_subgraphs:
                 mermaid_graph += f"\tsubgraph {prefix}\n"
 
                 # Add nodes that belong to this subgraph
-                for key, node in subgraph_nodes[prefix].items():
+                for key, node in subgraph_node.items():
                     mermaid_graph += render_node(key, node)
 
                 mermaid_graph += "\tend\n"

libs/core/langchain_core/runnables/utils.py

@@ -23,7 +23,7 @@
 from typing_extensions import TypeGuard, override
 
 # Re-export create-model for backwards compatibility
-from langchain_core.utils.pydantic import create_model as create_model
+from langchain_core.utils.pydantic import create_model  # noqa: F401
 
 if TYPE_CHECKING:
     from collections.abc import (
@@ -38,9 +38,9 @@
 
     from langchain_core.runnables.schema import StreamEvent
 
-Input = TypeVar("Input", contravariant=True)
+Input = TypeVar("Input", contravariant=True)  # noqa: PLC0105
 # Output type should implement __concat__, as eg str, list, dict do
-Output = TypeVar("Output", covariant=True)
+Output = TypeVar("Output", covariant=True)  # noqa: PLC0105
 
 
 async def gated_coro(semaphore: asyncio.Semaphore, coro: Coroutine) -> Any:

libs/core/langchain_core/tools/__init__.py

@@ -20,45 +20,51 @@
 from __future__ import annotations
 
 from langchain_core.tools.base import (
-    FILTERED_ARGS as FILTERED_ARGS,
-)
-from langchain_core.tools.base import (
-    ArgsSchema as ArgsSchema,
-)
-from langchain_core.tools.base import (
-    BaseTool as BaseTool,
-)
-from langchain_core.tools.base import (
-    BaseToolkit as BaseToolkit,
-)
-from langchain_core.tools.base import (
-    InjectedToolArg as InjectedToolArg,
-)
-from langchain_core.tools.base import InjectedToolCallId as InjectedToolCallId
-from langchain_core.tools.base import SchemaAnnotationError as SchemaAnnotationError
-from langchain_core.tools.base import (
-    ToolException as ToolException,
-)
-from langchain_core.tools.base import (
-    _get_runnable_config_param as _get_runnable_config_param,
-)
-from langchain_core.tools.base import (
-    create_schema_from_function as create_schema_from_function,
+    FILTERED_ARGS,
+    ArgsSchema,
+    BaseTool,
+    BaseToolkit,
+    InjectedToolArg,
+    InjectedToolCallId,
+    SchemaAnnotationError,
+    ToolException,
+    _get_runnable_config_param,
+    create_schema_from_function,
 )
 from langchain_core.tools.convert import (
-    convert_runnable_to_tool as convert_runnable_to_tool,
-)
-from langchain_core.tools.convert import tool as tool
-from langchain_core.tools.render import ToolsRenderer as ToolsRenderer
-from langchain_core.tools.render import (
-    render_text_description as render_text_description,
+    convert_runnable_to_tool,
+    tool,
 )
 from langchain_core.tools.render import (
-    render_text_description_and_args as render_text_description_and_args,
+    ToolsRenderer,
+    render_text_description,
+    render_text_description_and_args,
 )
-from langchain_core.tools.retriever import RetrieverInput as RetrieverInput
 from langchain_core.tools.retriever import (
-    create_retriever_tool as create_retriever_tool,
+    RetrieverInput,
+    create_retriever_tool,
 )
-from langchain_core.tools.simple import Tool as Tool
-from langchain_core.tools.structured import StructuredTool as StructuredTool
+from langchain_core.tools.simple import Tool
+from langchain_core.tools.structured import StructuredTool
+
+__all__ = [
+    "ArgsSchema",
+    "BaseTool",
+    "BaseToolkit",
+    "FILTERED_ARGS",
+    "SchemaAnnotationError",
+    "ToolException",
+    "InjectedToolArg",
+    "InjectedToolCallId",
+    "_get_runnable_config_param",
+    "create_schema_from_function",
+    "convert_runnable_to_tool",
+    "tool",
+    "ToolsRenderer",
+    "render_text_description",
+    "render_text_description_and_args",
+    "RetrieverInput",
+    "create_retriever_tool",
+    "Tool",
+    "StructuredTool",
+]

libs/core/langchain_core/utils/mustache.py

@@ -324,8 +324,8 @@ def _html_escape(string: str) -> str:
 
     # & must be handled first
     string = string.replace("&", "&")
-    for char in html_codes:
-        string = string.replace(char, html_codes[char])
+    for char, code in html_codes.items():
+        string = string.replace(char, code)
     return string
 
 

libs/core/pyproject.toml

@@ -101,8 +101,6 @@ ignore = [
     "FBT002",
     "FIX",
     "PGH",
-    "PLC",
-    "PLE",
     "PLR",
     "PYI",
     "RET",

libs/core/tests/unit_tests/language_models/chat_models/test_rate_limiting.py

@@ -1,5 +1,4 @@
 import time
-from typing import Optional as Optional
 
 import pytest
 from blockbuster import BlockBuster

libs/core/tests/unit_tests/output_parsers/test_base_parsers.py

@@ -1,7 +1,5 @@
 """Module to test base parser implementations."""
 
-from typing import Optional as Optional
-
 from langchain_core.exceptions import OutputParserException
 from langchain_core.language_models import GenericFakeChatModel
 from langchain_core.messages import AIMessage

libs/core/tests/unit_tests/runnables/test_runnable_events_v1.py

@@ -5,7 +5,6 @@
 from collections.abc import AsyncIterator, Sequence
 from itertools import cycle
 from typing import Any, cast
-from typing import Optional as Optional
 
 import pytest
 from pydantic import BaseModel