Skip to content

community: add mypy warn_unused_ignores rule #30816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Apr 14, 2025

No description provided.

Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2025 0:09am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community labels Apr 14, 2025
@cbornet cbornet force-pushed the community-remove-type-ignore branch from 3d8794a to 7ca16f6 Compare April 14, 2025 08:47
@sydney-runkle
Copy link
Collaborator

@cbornet, thanks for all of these PRs - I'll be reviewing this week!

@cbornet cbornet force-pushed the community-remove-type-ignore branch 2 times, most recently from c327ff6 to 044dac2 Compare April 15, 2025 12:04
@cbornet cbornet force-pushed the community-remove-type-ignore branch from 044dac2 to dc6fe63 Compare April 15, 2025 12:08
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 28, 2025
@ccurme
Copy link
Collaborator

ccurme commented Apr 28, 2025

Thanks @cbornet. I scanned through this but am assuming you'd give a heads up if there are any changes aside from updating type-ignores.

@ccurme ccurme merged commit aee7988 into langchain-ai:master Apr 28, 2025
260 checks passed
@cbornet cbornet deleted the community-remove-type-ignore branch April 28, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants