Skip to content

Commit 9f05fbc

Browse files
Merge pull request #31 from lara-zeus/fix/missing-markable-morphToMany-related-pivot-key
fix(relations): set `relatedPivotKey` in `morphToMany` relation
2 parents ce95f14 + d92d892 commit 9f05fbc

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

src/Traits/Bookmark/Bookmarkable.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ trait Bookmarkable
1515
{
1616
public function bookmarkedBy()
1717
{
18-
return $this->morphToMany(Mark::getMarkerModel(), 'markable', (new (Mark::getBookmarkMorphPivotModel()))->getTable())
18+
return $this->morphToMany(
19+
related: Mark::getMarkerModel(),
20+
name: 'markable',
21+
table: (new (Mark::getBookmarkMorphPivotModel()))->getTable(),
22+
relatedPivotKey: 'marker_id'
23+
)
24+
1925
->using(Mark::getBookmarkMorphPivotModel())
2026
->withPivot(['value', 'metadata'])
2127
->withTimestamps();

src/Traits/Like/Likeable.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,12 @@ trait Likeable
1515
{
1616
public function likedBy()
1717
{
18-
return $this->morphToMany(Mark::getMarkerModel(), 'markable', (new (Mark::getLikeMorphPivotModel()))->getTable())
18+
return $this->morphToMany(
19+
related: Mark::getMarkerModel(),
20+
name: 'markable',
21+
table: (new (Mark::getLikeMorphPivotModel()))->getTable(),
22+
relatedPivotKey: 'marker_id'
23+
)
1924
->using(Mark::getLikeMorphPivotModel())
2025
->withPivot(['value', 'metadata'])
2126
->withTimestamps();

src/Traits/Rating/Rateable.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,12 @@ trait Rateable
1515
{
1616
public function ratedBy()
1717
{
18-
return $this->morphToMany(Mark::getMarkerModel(), 'markable', (new (Mark::getRatingMorphPivotModel()))->getTable())
18+
return $this->morphToMany(
19+
related: Mark::getMarkerModel(),
20+
name: 'markable',
21+
table: (new (Mark::getRatingMorphPivotModel()))->getTable(),
22+
relatedPivotKey: 'marker_id'
23+
)
1924
->using(Mark::getRatingMorphPivotModel())
2025
->withPivot(['value', 'metadata'])
2126
->withTimestamps();

0 commit comments

Comments
 (0)