Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Suggestion : Modify storage variable in default config file #1444

Closed
wants to merge 2 commits into from
Closed

[5.x] Suggestion : Modify storage variable in default config file #1444

wants to merge 2 commits into from

Conversation

mho22
Copy link

@mho22 mho22 commented Mar 15, 2024

During the Laravel 11 update, I encountered a minor issue. Since I have a dedicated database for data from Pulse or Telescope, I needed to redirect connections to this database when loading the Pulse and Telescope dashboards.

For Pulse, it's straightforward to implement this using an environment variable called 'PULSE_DB_CONNECTION.' However, Telescope has a similar configuration with the environment variable 'DB_CONNECTION,' which is the database.default connection env variable.

A workaround could be to rewrite this in a dedicated config file, of course. However, I still thought it would be beneficial to suggest this pull request due to the current behavior of Pulse.

Pulse's default config file storage value :

'storage' => [
    'driver' => env('PULSE_STORAGE_DRIVER', 'database'),

    'database' => [
        'connection' => env('PULSE_DB_CONNECTION', null),
        'chunk' => 1000,
    ],
],

Telescope's default config file driver and storage values :

'driver' => env('TELESCOPE_DRIVER', 'database'),

'storage' => [
    'database' => [
        'connection' => env('DB_CONNECTION', 'mysql'),
        'chunk' => 1000,
    ],
],

P.S.: The description has been copied and pasted from the Pulse description and used for Telescope.

@driesvints
Copy link
Member

This is a major breaking change for people who have published the telescope config file.

@mho22
Copy link
Author

mho22 commented Mar 15, 2024

You're right.

@mho22 mho22 deleted the modify-storage-values-in-config-file-patch branch March 15, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants