Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure formatForTelescope method is used in request watcher #1566

Merged

Conversation

duncanmcclean
Copy link
Contributor

In #1562, I made it possible for developers to hook into how objects are seralized by Telescope by adding a formatForTelescope method to your objects.

public function formatForTelescope(): array
{
    // Returns a different representation of this class
}

In our case, this method allows us to prevent infinite loops.

However, during some additional testing on our end, I realised that I forgot to implement this hook for the RequestWatcher which serialized the variables available in Blade views.

I've provided a test for this change.

@taylorotwell taylorotwell merged commit 8f5aca9 into laravel:5.x Feb 6, 2025
18 checks passed
@duncanmcclean duncanmcclean deleted the format-for-telescope-request-watcher branch February 11, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants