Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid truncating displayed data in tables #1573

Closed
wants to merge 1 commit into from

Conversation

mRoca
Copy link

@mRoca mRoca commented Mar 11, 2025

Currently, all main data in tables are truncated with an arbitrary length.

This PR is based on https://stackoverflow.com/a/50605906 hack (text-overflow: ellipsis + overflow: hidden + width; 100% +max-width: 0) and transform all JS arbitrary truncate into css overflow-ellipsis at max possible length.

Before:

Screenshot from 2025-03-11 17-50-21

After:

Screenshot from 2025-03-11 17-49-11

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@mRoca
Copy link
Author

mRoca commented Mar 12, 2025

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@taylorotwell why not adding a No contribution allowed / wanted somewhere in README.md, or in https://laravel.com/docs/12.x/contributions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants