Revert "Remove coroutines (FreeRTOS#874)" (FreeRTOS#1019)

* Revert "Remove coroutines (FreeRTOS#874)"

This reverts commit 569c78f.

* Update freertos Kernel submodule to latest head

* Remove temporary files

* Fix MingW demos and spell check

* Fix manifest version; fix headers

* Add ignore files and paths to core-checker.py

* Fix copyright in remaining files

* Fix PR check build failure

1. Remove defining `inline` in Makefile. This was causing build
   warnings.
2. Ensure that the linker removed unused functions from various
   compilation units.
3. Update the linker script so that all the functions are correctly
   placed in FLASH section.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

---------

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Co-authored-by: Gaurav Aggarwal <aggarg@amazon.com>

Author: AniruddhaKanhere

.github/scripts/core_checker.py

@@ -306,7 +306,6 @@
     'interrupt_vector.s',
     'reg_test.S',
     'gdbinit',
-
 ]
 
 FREERTOS_HEADER = [
@@ -358,4 +357,3 @@ def main():
 
 if __name__ == '__main__':
     exit(main())
-

FreeRTOS/Demo/ARM7_AT91FR40008_GCC/FreeRTOSConfig.h

@@ -38,7 +38,7 @@
  * application requirements.
  *
  * THESE PARAMETERS ARE DESCRIBED WITHIN THE 'CONFIGURATION' SECTION OF THE
- * FreeRTOS API DOCUMENTATION AVAILABLE ON THE FreeRTOS.org WEB SITE.
+ * FreeRTOS API DOCUMENTATION AVAILABLE ON THE FreeRTOS.org WEB SITE. 
  *
  * See http://www.freertos.org/a00110.html
  */
@@ -59,6 +59,9 @@
 #define configUSE_16_BIT_TICKS		0
 #define configIDLE_SHOULD_YIELD		1
 
+/* Co-routine definitions. */
+#define configUSE_CO_ROUTINES 		0
+#define configMAX_CO_ROUTINE_PRIORITIES ( 2 )
 
 /* Set the following definitions to 1 to include the API function, or zero
 to exclude the API function. */

FreeRTOS/Demo/ARM7_AT91FR40008_GCC/ParTest/ParTest.c

@@ -64,7 +64,7 @@ void vParTestInitialise( void )
 {
 	/* This is performed from main() as the io bits are shared with other setup
 	functions.  Ensure the outputs are off to start. */
-	ulLEDReg = partstALL_OUTPUTS_OFF;
+	ulLEDReg = partstALL_OUTPUTS_OFF;  
 
 	/* Enable clock to PIO... */
 	AT91C_BASE_PS->PS_PCER = AT91C_PS_PIO;

FreeRTOS/Demo/ARM7_AT91FR40008_GCC/serial/serial.c

@@ -24,8 +24,8 @@
  *
  */
 
-/*
-	BASIC INTERRUPT DRIVEN SERIAL PORT DRIVER FOR USART0.
+/* 
+	BASIC INTERRUPT DRIVEN SERIAL PORT DRIVER FOR USART0. 
 
 	This file contains all the serial port components that can be compiled to
 	either ARM or THUMB mode.  Components that must be compiled to ARM mode are
@@ -60,14 +60,14 @@
 
 /* Queues used to hold received characters, and characters waiting to be
 transmitted. */
-static QueueHandle_t xRxedChars;
-static QueueHandle_t xCharsForTx;
+static QueueHandle_t xRxedChars; 
+static QueueHandle_t xCharsForTx; 
 
 /*-----------------------------------------------------------*/
 
-/*
+/* 
  * The queues are created in serialISR.c as they are used from the ISR.
- * Obtain references to the queues and THRE Empty flag.
+ * Obtain references to the queues and THRE Empty flag. 
  */
 extern void vSerialISRCreateQueues(  unsigned portBASE_TYPE uxQueueLength, QueueHandle_t *pxRxedChars, QueueHandle_t *pxCharsForTx );
 
@@ -84,10 +84,10 @@ extern void ( vUART_ISR_Wrapper )( void );
 	serialISR.c (which is always compiled to ARM mode. */
 	vSerialISRCreateQueues( uxQueueLength, &xRxedChars, &xCharsForTx );
 
-	if(
-		( xRxedChars != serINVALID_QUEUE ) &&
-		( xCharsForTx != serINVALID_QUEUE ) &&
-		( ulWantedBaud != ( unsigned long ) 0 )
+	if( 
+		( xRxedChars != serINVALID_QUEUE ) && 
+		( xCharsForTx != serINVALID_QUEUE ) && 
+		( ulWantedBaud != ( unsigned long ) 0 ) 
 	  )
 	{
 		portENTER_CRITICAL();
@@ -109,10 +109,10 @@ extern void ( vUART_ISR_Wrapper )( void );
 			AT91C_BASE_US0->US_TCR = 0;
 
 			/* Input clock to baud rate generator is MCK */
-			ulSpeed = configCPU_CLOCK_HZ * 10;
+			ulSpeed = configCPU_CLOCK_HZ * 10;  
 			ulSpeed = ulSpeed / 16;
 			ulSpeed = ulSpeed / ulWantedBaud;
-
+			
 			/* compute the error */
 			ulCD  = ulSpeed / 10;
 			if ((ulSpeed - (ulCD * 10)) >= 5)
@@ -131,10 +131,10 @@ extern void ( vUART_ISR_Wrapper )( void );
 
 			Store interrupt handler function address in USART0 vector register... */
 			AT91C_BASE_AIC->AIC_SVR[ portUSART0_AIC_CHANNEL ] = (unsigned long)vUART_ISR_Wrapper;
-
+			
 			/* USART0 interrupt level-sensitive, priority 1... */
 			AT91C_BASE_AIC->AIC_SMR[ portUSART0_AIC_CHANNEL ] = AIC_SRCTYPE_INT_LEVEL_SENSITIVE | 1;
-
+			
 			/* Clear some pending USART0 interrupts (just in case)... */
 			AT91C_BASE_US0->US_CR = US_RSTSTA;
 

FreeRTOS/Demo/ARM7_AT91FR40008_GCC/serial/serialISR.c

@@ -25,8 +25,8 @@
  */
 
 
-/*
-  BASIC INTERRUPT DRIVEN SERIAL PORT DRIVER FOR USART0.
+/* 
+  BASIC INTERRUPT DRIVEN SERIAL PORT DRIVER FOR USART0. 
 
   This file contains all the serial port components that must be compiled
   to ARM mode.  The components that can be compiled to either ARM or THUMB
@@ -61,16 +61,16 @@
 
 /* Queues used to hold received characters, and characters waiting to be
 transmitted. */
-static QueueHandle_t xRxedChars;
-static QueueHandle_t xCharsForTx;
+static QueueHandle_t xRxedChars; 
+static QueueHandle_t xCharsForTx; 
 
 /*-----------------------------------------------------------*/
 
 /* UART0 interrupt service routine.  This can cause a context switch so MUST
 be declared "naked". */
 void vUART_ISR_Wrapper( void ) __attribute__ ((naked));
 
-/* The ISR function that actually performs the work.  This must be separate
+/* The ISR function that actually performs the work.  This must be separate 
 from the wrapper to ensure the correct stack frame is set up. */
 void vUART_ISR_Handler( void ) __attribute__ ((noinline));
 
@@ -81,7 +81,7 @@ void vSerialISRCreateQueues( unsigned portBASE_TYPE uxQueueLength, QueueHandle_t
 	xRxedChars = xQueueCreate( uxQueueLength, ( unsigned portBASE_TYPE ) sizeof( signed char ) );
 	xCharsForTx = xQueueCreate( uxQueueLength + 1, ( unsigned portBASE_TYPE ) sizeof( signed char ) );
 
-	/* Pass back a reference to the queues so the serial API file can
+	/* Pass back a reference to the queues so the serial API file can 
 	post/receive characters. */
 	*pxRxedChars = xRxedChars;
 	*pxCharsForTx = xCharsForTx;
@@ -93,7 +93,7 @@ void vUART_ISR_Wrapper( void )
 	/* Save the context of the interrupted task. */
 	portSAVE_CONTEXT();
 
-	/* Call the handler.  This must be a separate function to ensure the
+	/* Call the handler.  This must be a separate function to ensure the 
 	stack frame is correctly set up. */
 	__asm volatile( "bl vUART_ISR_Handler" );
 
@@ -126,7 +126,7 @@ unsigned long ulStatus;
 		{
 			/* Queue empty, nothing to send so turn off the Tx interrupt. */
 			AT91C_BASE_US0->US_IDR = US_TXRDY;
-		}
+		}    
 	}
 
 	if (ulStatus & US_RXRDY)

FreeRTOS/Demo/ARM7_AT91SAM7S64_IAR/FreeRTOSConfig.h

@@ -37,7 +37,7 @@
  * application requirements.
  *
  * THESE PARAMETERS ARE DESCRIBED WITHIN THE 'CONFIGURATION' SECTION OF THE
- * FreeRTOS API DOCUMENTATION AVAILABLE ON THE FreeRTOS.org WEB SITE.
+ * FreeRTOS API DOCUMENTATION AVAILABLE ON THE FreeRTOS.org WEB SITE. 
  *
  * See http://www.freertos.org/a00110.html
  -----------------------------------------------------------*/
@@ -55,6 +55,9 @@
 #define configUSE_16_BIT_TICKS		0
 #define configIDLE_SHOULD_YIELD		1
 
+/* Co-routine definitions. */
+#define configUSE_CO_ROUTINES 		0
+#define configMAX_CO_ROUTINE_PRIORITIES ( 2 )
 
 /* Set the following definitions to 1 to include the API function, or zero
 to exclude the API function. */

FreeRTOS/Demo/ARM7_AT91SAM7S64_IAR/ParTest/ParTest.c

@@ -35,9 +35,9 @@
 const unsigned long led_mask[ NB_LED ]= { LED1, LED2, LED3, LED4 };
 
 void vParTestInitialise( void )
-{
+{	
 	/* Start with all LED's off. */
-	AT91F_PIO_SetOutput( AT91C_BASE_PIOA, LED_MASK );
+	AT91F_PIO_SetOutput( AT91C_BASE_PIOA, LED_MASK );	
 }
 /*-----------------------------------------------------------*/
 
@@ -67,7 +67,7 @@ void vParTestToggleLED( unsigned portBASE_TYPE uxLED )
 		}
 		else
 		{
-			AT91F_PIO_SetOutput( AT91C_BASE_PIOA, led_mask[ uxLED ] );
+			AT91F_PIO_SetOutput( AT91C_BASE_PIOA, led_mask[ uxLED ] );					
 		}
 	}
 }