Skip to content

Commit dbc4d23

Browse files
authored
chore: Fix broken pypi publish action (#34)
According to [this GitHub issue][1], the `pypa/gh-action-pypi-publish` action cannot be used in nested actions. This commit inlines the usage of this action into the top-level workflows instead. [1]: pypa/gh-action-pypi-publish#299
1 parent dc70fcb commit dbc4d23

File tree

3 files changed

+7
-24
lines changed

3 files changed

+7
-24
lines changed

.github/actions/publish/action.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

.github/workflows/manual-publish.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ jobs:
3232

3333
- uses: ./.github/actions/build
3434

35-
- uses: ./.github/actions/publish
35+
- name: Publish package distributions to PyPI
36+
if: ${{ inputs.dry_run == false }}
37+
uses: pypa/gh-action-pypi-publish@release/v1
3638
with:
37-
token: ${{env.PYPI_AUTH_TOKEN}}
38-
dry_run: ${{ inputs.dry_run }}
39+
password: ${{env.PYPI_AUTH_TOKEN}}

.github/workflows/release-please.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ jobs:
4343
- uses: ./.github/actions/build-docs
4444
if: ${{ steps.release.outputs.releases_created == 'true' }}
4545

46-
- uses: ./.github/actions/publish
46+
- name: Publish package distributions to PyPI
4747
if: ${{ steps.release.outputs.releases_created == 'true' }}
48+
uses: pypa/gh-action-pypi-publish@release/v1
4849
with:
49-
token: ${{env.PYPI_AUTH_TOKEN}}
50-
dry_run: false
50+
password: ${{env.PYPI_AUTH_TOKEN}}
5151

5252
- uses: ./.github/actions/publish-docs
5353
if: ${{ steps.release.outputs.releases_created == 'true' }}

0 commit comments

Comments
 (0)