iOS: Accessibility: Fix to-do completion status can't be changed from the note list #12101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an accessibility issue on iOS — the checkbox for note list items and the note list item description were both included in the same
<Pressable
. Although Android allowed focusing the checkbox and note list item title individually, this was not possible on iOS. As a result, it was previously necessary to open a note before its completion status could be changed.This pull request moves the to-do checkbox outside of the pressable item that opens a note. To continue applying the press-related opacity animation to both the checkbox and the note title, a new
MultiTouchableOpacity
component is created. When the main touchable component in a MultiTouchableOpacity is pressed, the opacity animation is applied to both the main touchable and any additional components.Testing plan
iOS 18, Android 13
to-do: Test, unchecked
on iOS,not checked, to-do: Test, checkbox
on Android).