Skip to content

iOS: Accessibility: Fix to-do completion status can't be changed from the note list #12101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes an accessibility issue on iOS — the checkbox for note list items and the note list item description were both included in the same <Pressable. Although Android allowed focusing the checkbox and note list item title individually, this was not possible on iOS. As a result, it was previously necessary to open a note before its completion status could be changed.

This pull request moves the to-do checkbox outside of the pressable item that opens a note. To continue applying the press-related opacity animation to both the checkbox and the note title, a new MultiTouchableOpacity component is created. When the main touchable component in a MultiTouchableOpacity is pressed, the opacity animation is applied to both the main touchable and any additional components.

Testing plan

iOS 18, Android 13

  1. Create two or more to-dos.
  2. Move the focus to the top of the note list.
  3. Navigate through the to-dos.
    • Verify that the label for each checkbox includes a description of its associated note (e.g. to-do: Test, unchecked on iOS, not checked, to-do: Test, checkbox on Android).
    • Note: On Android, this change moves the checkbox before the "opens note" button in the focus order.
  4. Move focus to the first checkbox and double-tap.
  5. Verify that the to-do (previously incomplete) is marked as complete.
  6. Move focus to the label associated with the to-do.
  7. Double-tap.
  8. Verify that this opens the to-do in the note viewer.

@laurent22 laurent22 merged commit 9871717 into laurent22:dev Apr 14, 2025
11 checks passed
@personalizedrefrigerator
Copy link
Collaborator Author

Related: #11661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants