Skip to content

Text URL containing a query string is marked by "cm-url" CSS class incorrectly #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexgoussev opened this issue Apr 15, 2025 · 2 comments
Labels
bug It's a bug

Comments

@alexgoussev
Copy link

alexgoussev commented Apr 15, 2025

Operating system

Windows

Joplin version

3.3.4

Desktop version info

Joplin 3.3.4 (prod, win32)

Device: win32, x64
Client ID: a6436183336d4b8192b3f60b919551f6
Sync Version: 3
Profile Version: 47
Keychain Supported: No
Alternative instance ID: -

Revision: 821558f

Current behaviour

Create some text URL with a query string in the editor.
Look at development tools.
You will see that URL query string is placed outside of <span class="cm-url" ... > HTML tag.

A text in the editor:
http://website.com?key=value

HTML code in development tools window:

<div class="cm-line" dir="auto">
    <span class="cm-url" spellcheck="false" autocorrect="false">
        <span class="ͼ1h tok-url">http://website.com</span>
    </span>
    ?key=value
</div>

Expected behaviour

The main URL and its' query string should be placed together inside of <span class="cm-url" ... > HTML tag.

Logs

No response

@alexgoussev alexgoussev added the bug It's a bug label Apr 15, 2025
@laurent22
Copy link
Owner

We'd need to know why it matters, what's the actual bug

@alexgoussev
Copy link
Author

alexgoussev commented Apr 17, 2025

It breaks "Extended Markdown editor settings" plugin.
Because of it the plugin renders simple url
http://website.com?key=value
like so
http://website.com?key=value
in the editor window.
But it should be rendered like this
http://website.com?key=value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants