Skip to content

Web: Fix tapping outside alert/confirm dialogs doesn't dismiss them correctly #12144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 22, 2025

Summary

This pull request fixes an issue where calls to shim.showMessageBox could return a promise that never resolves if the dialog was dismissed by tapping on its background. This issue was present on web and possibly Android.

Testing plan

In addition to this pull request's automated test, the change has been tested manually by:

  1. Opening the plugin configuration screen.
  2. Installing an invalid plugin from a file.
  3. Waiting for the error dialog to be shown.
  4. Tapping outside of the dialog to dismiss it.
  5. Verifying that the "Installing" button no longer shows a "loading" indicator.

@laurent22
Copy link
Owner

There's a conflict on one file

@laurent22 laurent22 merged commit 807bcdc into laurent22:dev Apr 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants