iOS: Accessibility: Fix plugins can't be installed using VoiceOver #11931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where buttons within an installable plugin's card were not focusable using VoiceOver (they worked as expected using TalkBack on Android). The issue was caused by the card wrapper having been marked as accessible=true, which prevented VoiceOver from focusing elements within the card. With this change, the card is only marked as accessible when it's clickable (when the plugin is already installed). Manual testing (iOS 18.1 simulator): 1. Move VoiceOver focus to an installed plugin's card. 2. Activate it with ctrl-option-space. 3. Verify that this shows a dialog. 4. Close the dialog and search for "Rich" in the plugin search. 5. Move focus to Rich Markdown's 'Install' button. - Verify that VoiceOver describes this button as "Install Rich Markdown, button". 6. Install Rich Markdown using VoiceOver (activate the button with ctrl-option-space). 7. Verify that this installs Rich Markdown.
|
Related: #11661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where buttons within an installable plugin's card were not focusable using VoiceOver (they worked as expected using TalkBack on Android). If VoiceOver is considered a "keyboard interface", this may be related to WCAG 2.2's SC 2.1.1.
The issue was caused by the card wrapper having
accessible=true, which prevented VoiceOver from focusing elements within the card. With this pull request, the card is markedaccessible=trueonly when the full card is clickable (when the plugin is already installed).Testing plan
Manual testing (iOS 18.1 simulator):