Desktop: Resolves issue #12039: Checks whether there exists a deleted folder in order to determine if Trash is collapsible

[MorbidMiyako]

The new approach simply checks if there exists a folder with a deleted_time.
It seems that the only aspect influencing whether Trash is collapsible is the presence of a folder.
If this is to change, then its likely this information can be found in the store.
There are also a few safeguards implemented.
FIrstly, if the issue of the Trash folder.childern.size reporting 0 regardless is resolved, it will simply skip over this addition.
Secondly, by breaking as soon as proof is found Trash contains a folder any unnecessary iterations are prevented.

Using the store might allow for determining the number of items in the Trash, something that was commented to be considered tricky. Although I assume communication regarding this subject should be moved to the forum.

Following is a visual explanation of the new behaviour:

By clicking the collapse all button its now possible to go between the following two states:

See issue #12039 for more information regarding the bug that's resolved.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[MorbidMiyako]

I have read the CLA Document and I hereby sign the CLA

[laurent22]

Thanks for looking into it. Does that also collapse/expand the nested notebooks inside the trash folder?

[laurent22]

Also it would be good to add tests if possible. I seem to remember I've added some for the collapse/expand logic

[MorbidMiyako]

In response to your first question, yes all folders inside of Trash are also collapsed/expanded.
I did not find a test for this file yet, but I've made one.
It works on the same assumption that if there is a folder in Trash then Trash should be collapsable/expandable.

[personalizedrefrigerator]

Thank you for working on this (and adding tests)!

I've left two comments.

[MorbidMiyako]

All issues should now be resolved, let me know if there is anything else

[MorbidMiyako]

@personalizedrefrigerator Please let me know if there are any other changes needed/desired.