Android: Improve UI for downloading updated voice typing models #12145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, updated models were downloaded after starting voice typing with the old model. This change adjusts that behavior. With this change, a dialog is shown if the downloaded voice typing model is outdated. The dialog allows users to choose to download the updated model or continue using the outdated model. Previously, an outdated model would show the "Download updated model" button in the voice typing banner and start voice with the old model. Testing: 1. Change the voice typing URL in settings 2. Open a note 3. Start voice typing 4. Click "Cancel" in the "Download updated model?" dialog. 5. Say something and click "Done". 6. Verify that the text is added to the document. 7. Start voice typing again. 8. Click "OK" in the "Download updated model?" dialog. 9. Wait for the model to download. 10. Verify that voice typing starts. 11. Say something. 12. Click "Done". 13. Verify that text from step 11 is transcribed.
personalizedrefrigerator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, updated models were downloaded after starting voice typing with the old model. This change adjusts that behavior.
With this change, a dialog is shown if the downloaded voice typing model is outdated. The dialog allows users to choose to download the updated model or continue using the outdated model.
Before this change, an outdated model would show the "Download updated model" button in the voice typing banner and start voice with the old model.
Resolves #11998.
Screenshot
Testing plan
On Android 13: