Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mariadb mariadb-server, upodated magmad install script #160

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

brokep
Copy link

@brokep brokep commented Jan 10, 2024

mysql is no longer included in the repos so I have added mariadb & mariadb-server in the installation requirements.

mysql is no longer included in the repos
updated readme to include mariadb & mariadb-server to the installation requirements because mysql is not in the repos
@brokep
Copy link
Author

brokep commented Jan 10, 2024

mysql is no in the repo so i have added the proper replacement, mariadb & mariadb-server

Copy link
Author

@brokep brokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the packages needed to compile/run magm.

Use set -euo pipefail: This will make the script exit immediately if a command fails, a variable is undefined, or a pipeline returns a non-zero status.

Modularize the Script: Break the script into functions for each major task (e.g., install_packages, configure_mysql, setup_firewall). This makes it easier to read and maintain.

Add Logging: Implement logging to capture the script's output and errors, which can be useful for debugging and auditing.

Progress Indicators: Provide feedback to the user about what the script is doing, especially for long-running tasks.
@brokep brokep changed the title adding mariadb mariadb-server adding mariadb mariadb-server, upodated magmad install script Feb 12, 2025
@@ -15,7 +17,7 @@ DOMAIN="example.com"
# TLSKEY="/root/example.com.pem"

# The DKIM key file. Leave commented out to generate a new key and print the associated DNS record.
# DKIMKEY="/root/dkim.example.com.pem"
# DKIMKEY="/root/dkim.example.co m.pem"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not reflected in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants