Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate helm charts archieve (<=v0.8.133) #440

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

vishalvivekm
Copy link
Contributor

@vishalvivekm vishalvivekm commented Feb 3, 2025

Notes for Reviewers

Description

fixes #438
This PR reorganizes the helm charts by:

  • relocating chart tarballs (v0.8.133 and older) from static/charts/ to charts/ directory
  • consolidating static/charts/index.yaml into charts/index.yaml
  • updating tarball URLs in index.yaml to reflect new paths (replacing static/charts with charts for v0.8.133 and older versions)

Changes

  • Moved tarballs: static/charts/*.tgzcharts/*.tgz (v0.8.133 and older)
  • Merged index files (static/charts/index.yaml and charts/index.yaml)
  • Updated tarball URLs in index.yaml

Signed commits

  • Yes, I signed my commits.

Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 4d5bc04
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67a1b4e3bd7b40000830ebfc
😎 Deploy Preview https://deploy-preview-440--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sangramrath sangramrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after the one change requested.

charts/index.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to view the yaml in browser, it kept downloading the file instead of showing on browser. Is that normal in preview?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangramrath here you can view it: https://github.com/layer5io/docs/blob/4600c17238cd2bbec4cacc373b35632752c0f7e0/charts/index.yaml

when I clicked on view file: it opened it for me.
image

vishalvivekm and others added 3 commits February 4, 2025 11:57
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
@vishalvivekm vishalvivekm merged commit 89dbe42 into layer5io:master Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Helm package URL generated by helm release is invalid (404 Error)
2 participants