Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nvmrc file to ensure consistency of Node versions across Layer5 repositories #6229

Open
M-DEV-1 opened this issue Feb 10, 2025 · 3 comments · May be fixed by #6238
Open

Add .nvmrc file to ensure consistency of Node versions across Layer5 repositories #6229

M-DEV-1 opened this issue Feb 10, 2025 · 3 comments · May be fixed by #6238
Assignees
Labels
kind/bug Something isn't working

Comments

@M-DEV-1
Copy link

M-DEV-1 commented Feb 10, 2025

Currently, Layer5 repositories do not have a .nvmrc file (meshery/meshery has it), which helps enforce a consistent Node.js version for contributors. While Node.js versions are generally backward compatible, specifying a version helps:

  1. Prevent unexpected build or dependency issues due to version mismatches.

  2. Ensure security updates by standardizing on a maintained Node.js version.

  3. Improve developer experience by reducing environment inconsistencies.

Adding a .nvmrc file with the recommended Node.js version would be a small but valuable improvement.

Expected Behavior

Repositories should contain a .nvmrc file specifying the preferred Node.js version, ensuring consistency across development and deployment environments.

@M-DEV-1 M-DEV-1 added the kind/bug Something isn't working label Feb 10, 2025
@M-DEV-1 M-DEV-1 changed the title Add .nvmrc file to ensure consistency of Node versions across Layer5 repositories Add .nvmrc file to ensure consistency of Node versions across Layer5 repositories Feb 10, 2025
@M-DEV-1
Copy link
Author

M-DEV-1 commented Feb 10, 2025

@leecalcote
Copy link
Member

Thanks, @M-DEV-1!

@M-DEV-1
Copy link
Author

M-DEV-1 commented Feb 14, 2025

Thanks, @M-DEV-1!

Thank you for assigning this issue to me. I will work on this and submit a PR.

@M-DEV-1 M-DEV-1 linked a pull request Feb 14, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants