Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sistent] Select component doc #6177

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[Sistent] Select component doc #6177

wants to merge 11 commits into from

Conversation

nganphan123
Copy link

@nganphan123 nganphan123 commented Jan 6, 2025 •
edited
Loading

Description

This PR fixes #5957

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@nganphan123 nganphan123 force-pushed the select-component-doc branch 2 times, most recently from 522ad3b to 499335b Compare January 11, 2025 10:39
@nganphan123 nganphan123 marked this pull request as ready for review January 11, 2025 10:39
@l5io
Copy link
Contributor

l5io commented Jan 11, 2025

🚀 Preview for commit 499335b at: https://67824d17b7b47945fd85e5f8--layer5.netlify.app

@nganphan123
Copy link
Author

Hi @Vidit-Kushwaha , I finished adding the Select component. Could you help review the PR? Thank you!

@vishalvivekm
Copy link
Contributor

@nganphan123
Thank you for your contribution!
Let's discuss this during the website call on Monday at 7 AM CT.

adding it as an agenda item to the meeting minutes.

@vishalvivekm vishalvivekm changed the title Select component doc [Sistent] Select component doc Jan 13, 2025
@l5io
Copy link
Contributor

l5io commented Jan 21, 2025

🚀 Preview for commit 4e9faf2 at: https://678f00671bfff88dee48846d--layer5.netlify.app

Vidit-Kushwaha
Vidit-Kushwaha reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else look good to me

src/sections/Projects/Sistent/components/select/section-nav.js Outdated Show resolved Hide resolved
@nganphan123
add select route
fb63e8f 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
add overview page
22bbe9a 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
add component size
018b175 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
add multiple select
1cd5c61 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
extract section navigation and header
c1ffbdb 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
add guidance page
2e0ad10 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
add code section
248dce6 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
finish select code
5a14dbf 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
minor change
ff9c597 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
remove wrapper
1ab32ce 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@nganphan123
Copy link
Author

Hi @Vidit-Kushwaha @sudhanshutech thanks for reviewing my pr, I've made the necessary updates.

@l5io
Copy link
Contributor

l5io commented Jan 29, 2025

🚀 Preview for commit a2d6689 at: https://6799a6bc32f1e410da3927b8--layer5.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@sudhanshutech
Copy link
Member

@nganphan123 please sign in your commits otherwise looks good...

@nganphan123
move shared components to files
31dd0ba 
Signed-off-by: nganphan123 <jill01009@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 8, 2025

🚀 Preview for commit 31dd0ba at: https://67a7257d5c17bbc6481a1d69--layer5.netlify.app

@nganphan123
Copy link
Author

@nganphan123 please sign in your commits otherwise looks good...

Done!

Vidit-Kushwaha
Vidit-Kushwaha approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vidit-Kushwaha Vidit-Kushwaha Vidit-Kushwaha approved these changes

@sudhanshutech sudhanshutech Awaiting requested review from sudhanshutech

Assignees
No one assigned
Labels
issue/dco project/sistent
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Select component to the sistent components page
5 participants
@nganphan123 @l5io @vishalvivekm @sudhanshutech @Vidit-Kushwaha