Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding avatar component for sistent project #6221

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Jaishree2310
Copy link
Contributor

@Jaishree2310 Jaishree2310 commented Feb 3, 2025

Description

This PR fixes #6189

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 3, 2025

🚀 Preview for commit 076c93c at: https://67a081e257f70e7c7078138b--layer5.netlify.app

@Jaishree2310
Copy link
Contributor Author

Future to-do work: Adding avatar group component.
I will give an avatar group component draft PR and after reviewing and suggestions for changes will give the final PR.
Thanks!

@vishalvivekm
Copy link
Contributor

@Jaishree2310
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 3, 2025

🚀 Preview for commit 05b9349 at: https://67a0bf6092f0a8e9015ee308--layer5.netlify.app

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 3, 2025

🚀 Preview for commit 00f803c at: https://67a1060c43b9781b1aa588ad--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of issues @Jaishree2310

  1. There is not enough information in here
    {BA8808F4-9A43-486B-A497-E25938D64B08}

  2. As i click on guidance , the tab gets disappeared
    {71E60ABE-DFDA-47DB-BFFC-698DE701B9FA}

  3. the tile shouldn't be like this
    image

package.json Outdated Show resolved Hide resolved
@Jaishree2310
Copy link
Contributor Author

Hey @sudhanshutech, I will update this as per review.

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 4, 2025

🚀 Preview for commit da9e13f at: https://67a215b7b61bc53b87b0ad5f--layer5.netlify.app

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 4, 2025

🚀 Preview for commit 101422d at: https://67a21e12a8be5400acc03116--layer5.netlify.app

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 4, 2025

🚀 Preview for commit 6ceca58 at: https://67a24587bdbbee384b00383b--layer5.netlify.app

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given @Jaishree2310 some feedback; please take a look.

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 7, 2025

🚀 Preview for commit 113638d at: https://67a6246f9f22db13cb789090--layer5.netlify.app

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 7, 2025

🚀 Preview for commit f6cbdae at: https://67a62f93062ffc04bb73000d--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@Jaishree2310 conflicts.
Would you like to discuss your updates since the last discussion, on sites call today?
If yes, please add it to the meeting minutes:
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?usp=drivesdk

Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 10, 2025

🚀 Preview for commit 7e79a0d at: https://67a9f1c9a066fbbbce8ba338--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Projects] [Sistent] Publish Avatar and AvatarGroup as a components
5 participants