Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing filter tab overlapping with the top nav bar when hovered #6223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mash707
Copy link

@Mash707 Mash707 commented Feb 4, 2025

Description

I modified the filter tab so that it does not appear above the top nav when hovered

This PR fixes #6220

Notes for Reviewers
image
image
image
image

Signed commits

  • [✓ ] Yes, I signed my commits.

Signed-off-by: Divyanshu Gupta <divyanshugupta585@gmail.com>
@l5io
Copy link
Contributor

l5io commented Feb 4, 2025

🚀 Preview for commit a61d99e at: https://67a22a7f7c263503b64872ae--layer5.netlify.app

@Mash707
Copy link
Author

Mash707 commented Feb 6, 2025

@vishalvivekm could you review this one. Let me know if any changes are required. Thank you.

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is getting quite busy here, let’s move this div and its styles to membersGrid.style.js and use that instead of inline styles.

@vishalvivekm
Copy link
Contributor

@Mash707 while you're at it, the same issue is on https://layer5.io/company/news. Will you please look for more such places and include a fix for them as well?

@Mash707
Copy link
Author

Mash707 commented Feb 8, 2025

@Mash707 while you're at it, the same issue is on https://layer5.io/company/news. Will you please look for more such places and include a fix for them as well?

Should I include the fix in this PR or open a new issue? I'll also look for other places.

Signed-off-by: Divyanshu Gupta <divyanshugupta585@gmail.com>
@Mash707
Copy link
Author

Mash707 commented Feb 8, 2025

https://layer5.io/blog/category/announcements. This page has the search icon overlapping.
image

@l5io
Copy link
Contributor

l5io commented Feb 8, 2025

🚀 Preview for commit 65061f1 at: https://67a79b532d93a66fdab5c113--layer5.netlify.app

@Mash707 Mash707 requested a review from vishalvivekm February 8, 2025 18:26
@Mash707
Copy link
Author

Mash707 commented Feb 8, 2025

Should I include the fix in this PR or open a new issue? I'll also look for other places.

@vishalvivekm I am have the fix for other two issues mentioned.

@vishalvivekm
Copy link
Contributor

@Mash707

Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST
adding it as an agenda item to the meeting minutes.

@Mash707
Copy link
Author

Mash707 commented Feb 10, 2025

@vishalvivekm PR #6218 fixes this and other issues, so we don't require this PR. It can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Filter tab overlaps with the top nav bar tabs when hovered
3 participants