-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing filter tab overlapping with the top nav bar when hovered #6223
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Divyanshu Gupta <divyanshugupta585@gmail.com>
🚀 Preview for commit a61d99e at: https://67a22a7f7c263503b64872ae--layer5.netlify.app |
@vishalvivekm could you review this one. Let me know if any changes are required. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is getting quite busy here, let’s move this div
and its styles to membersGrid.style.js and use that instead of inline styles.
@Mash707 while you're at it, the same issue is on https://layer5.io/company/news. Will you please look for more such places and include a fix for them as well? |
Should I include the fix in this PR or open a new issue? I'll also look for other places. |
Signed-off-by: Divyanshu Gupta <divyanshugupta585@gmail.com>
https://layer5.io/blog/category/announcements. This page has the search icon overlapping. |
🚀 Preview for commit 65061f1 at: https://67a79b532d93a66fdab5c113--layer5.netlify.app |
@vishalvivekm I am have the fix for other two issues mentioned. |
Thank you for your contribution! |
@vishalvivekm PR #6218 fixes this and other issues, so we don't require this PR. It can be closed. |
Description
I modified the filter tab so that it does not appear above the top nav when hovered
This PR fixes #6220
Notes for Reviewers
![image](https://private-user-images.githubusercontent.com/114072061/409602412-aeeb0e6e-ad10-4976-aaeb-2aebfc63c2a9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDI5NTcsIm5iZiI6MTczOTQ0MjY1NywicGF0aCI6Ii8xMTQwNzIwNjEvNDA5NjAyNDEyLWFlZWIwZTZlLWFkMTAtNDk3Ni1hYWViLTJhZWJmYzYzYzJhOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMDMwNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iZWEzMGEyODk1ODc5MDRiZWYwNGYyMWY1YjE1MTA2Y2UwYmIxNGUzOGEwOGZiNmEyOTA1YTEzMDNhMWMxMjYxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ohDvjD6IHWv1kww21UGPsrtkiCQUtDCSp_rQnQ619Og)
![image](https://private-user-images.githubusercontent.com/114072061/409602614-3ffd3c52-ea69-4f36-8f0f-0b61622fbc9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDI5NTcsIm5iZiI6MTczOTQ0MjY1NywicGF0aCI6Ii8xMTQwNzIwNjEvNDA5NjAyNjE0LTNmZmQzYzUyLWVhNjktNGYzNi04ZjBmLTBiNjE2MjJmYmM5Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMDMwNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mYjU1MDE3YjQ4ODNjMTk0YTlkNTk4MDE3ZjgwMDg2OWUyMDc1NzgwMDNkNWVlYWQzMDkwNzhlZTlmYzExOGJkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.4FxQvisFGAYyaVXRZkfuZvYJSRqZ1Ht4EF4ipSJw_4k)
![image](https://private-user-images.githubusercontent.com/114072061/409602747-b9c4bc24-b88c-4ed3-9460-ff5b39239bfc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDI5NTcsIm5iZiI6MTczOTQ0MjY1NywicGF0aCI6Ii8xMTQwNzIwNjEvNDA5NjAyNzQ3LWI5YzRiYzI0LWI4OGMtNGVkMy05NDYwLWZmNWIzOTIzOWJmYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMDMwNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMzBhZTlkNWVjZDFjMWI1MjU0ZTU5MjE5ZGY4OTczMTZkOWUzMTNjMDFmZWFhNmRjODZhODVlYTdlYzhjYTM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.oy3zfSLfCeDHD4AicZ_NcfzvwqKSDjHm3zX1vSwvtjg)
![image](https://private-user-images.githubusercontent.com/114072061/409603211-810d2868-9d21-449e-8a94-b9bf9c02012a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDI5NTcsIm5iZiI6MTczOTQ0MjY1NywicGF0aCI6Ii8xMTQwNzIwNjEvNDA5NjAzMjExLTgxMGQyODY4LTlkMjEtNDQ5ZS04YTk0LWI5YmY5YzAyMDEyYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMDMwNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05YjU4YjVlMDhhY2M1ZGM0ZTBlNjg4YjFjNGUyNDVhNjIyYzZhNjRlZmM3MGQ3YWY2NmEzZWFkYWU5MTgxMjgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.vMRdENLYOTv_z7Of61_x3L24nbIB9JiZojhiM6_d55U)
Signed commits