Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text and image overlap in careers page #6226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix text and image overlap in careers page #6226

wants to merge 3 commits into from

Conversation

M-DEV-1
Copy link

@M-DEV-1 M-DEV-1 commented Feb 7, 2025

Description
This PR fixes the text overlap issue in the Open Source Internship section by increasing the margin below the image and adjusting PageHeader spacing to ensure proper separation.

This PR fixes #6225

Before:

After:

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@M-DEV-1
fix overlapping | add margin
f006aac 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1 M-DEV-1 changed the title fixes overlapping of images and text Fix text and image overlap in careers page Feb 7, 2025
@l5io
Copy link
Contributor

l5io commented Feb 7, 2025

🚀 Preview for commit f006aac at: https://67a5570f84dbccc837497cb9--layer5.netlify.app

vishalvivekm
vishalvivekm requested changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested a minor change

@M-DEV-1
Copy link
Author

M-DEV-1 commented Feb 9, 2025

Hi, I'll change it so that it doesn't affect the other sections which uses the component PageHeader

@M-DEV-1 M-DEV-1 requested a review from vishalvivekm February 10, 2025 03:52
@l5io
Copy link
Contributor

l5io commented Feb 10, 2025

🚀 Preview for commit 60af2d8 at: https://67a979bbe489e9d7763f5c3d--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 10, 2025

🚀 Preview for commit 08f7af3 at: https://67a9807fa47afee16d78f4ef--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@M-DEV-1
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@M-DEV-1
Copy link
Author

M-DEV-1 commented Feb 10, 2025

@vishalvivekm

Yes, I'll be there!

@leecalcote
Copy link
Member

@M-DEV-1, be sure to sign your commits.

@github-actions GitHub Actions
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
@github-actions GitHub Actions
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Assignees
No one assigned
Labels
issue/dco
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Responsiveness Issue on Careers Page
4 participants
@M-DEV-1 @l5io @vishalvivekm @leecalcote