fix(my-design): Update heading for Other Published Design to Other Public Design #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blic Design Signed-off-by: Vidit Kushwaha <viditkushwaha530@gmail.com>
amitamrutiya
requested changes
Jan 15, 2025
yes, I have checked it will change behaviour of catalog page |
that's what we don't want |
|
we want published for the catalog page and public for design page |
|
Is it done? |
|
To have a different text for different pages (catalog page and design page) we can add one more prop to component to check whether page is catalog or not or we can do pass a heading as an prop |
|
I think we already passed the props that necessary to differentiate the catalog and my-designs page |
Signed-off-by: Vidit Kushwaha <viditkushwaha530@gmail.com>
|
Yes we do pass relevant props, pushed changeous to PR Can you review again, @amitamrutiya |
amitamrutiya
requested changes
Feb 2, 2025
Signed-off-by: Vidit Kushwaha <viditkushwaha530@gmail.com>
|
@amitamrutiya pushed changeous |
amitamrutiya
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR updates the heading on the "My Design" page from "Other Published Design" to "Other Public Design" for better clarity and consistency with terminology.
Signed commits