Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mandatarissen producer to stop producing what OP produces #638

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

claire-lovisa
Copy link
Contributor

@claire-lovisa claire-lovisa commented Feb 11, 2025

⚠️ DO NOT MERGE BEFORE ALL KNOWN CONSUMERS HAVE BEEN UPDATED

Description

DL-6210

We are going to add the op-public-consumer to app-mandatendatabank, causing some triples being exported from Loket to MDB to be obsolete. In this PR, we:

  1. Remove parts of the configuration of the mandatarissen producer so that the triples coming from OP stop being produced by Loket
  2. Remove the same triples from the mandatarissen producer graph. This is to prevent annoying side effects as other applications consume from Loket and OP, for example it prevents having some administrative units being deleted from consuming applications.

Testing instructions

  1. Get a working Loket stack with some data in it. I tried on PROD data, maybe you can try with DEV or QA data, but whatever is the easiest for you
  2. Before checkout-ing this branch, run a healing to be sure to be up-to-date on your publication triplestore: drc exec delta-producer-background-jobs-initiator curl -X POST http://localhost/mandatarissen/healing-jobs
  3. Also run a dump drc exec delta-producer-background-jobs-initiator curl -X POST http://localhost/mandatarissen/dump-publication-graph-jobs
  4. Checkout this branch and drc restart migrations-publication-triplestore delta-producer-publication-graph-maintainer
  5. When the migrations are done running, run again a healing and when the healing is done a dump

Expected result:

  • After the healing, no deltas should have been produced about the resources removed from the configuration
  • The more recent dump should be substantially smaller and should not contain removed data

@cecemel
Copy link
Member

cecemel commented Feb 21, 2025

@benjay10 @claire-lovisa I approved this one. But we will only merge once all consumers are updated. So putting this on draft.
Note: I do find things without subject, but I think this is related to the implementation problems we discussed. (And unrelated to this PR)

@cecemel cecemel marked this pull request as draft February 21, 2025 17:02
@cecemel cecemel marked this pull request as draft February 21, 2025 17:02
@cecemel cecemel marked this pull request as draft February 21, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants