Prune leidingevenden producer to stop producing what OP produces #644
+63
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leidingevenden app will get their own OP-public-consumer to get all this data.
claire-lovisa
requested changes
Feb 21, 2025
There was a problem hiding this comment.
When running the healing after the flush + update of the configuration I noticed that some organen types were deleted by the producer. It's an issue because it means some consuming apps will have organen without a type ahah. I think it's because when the orgaan doesn't have a <http://data.lblod.info/vocabularies/leidinggevenden/heeftBestuursfunctie> triple, the type is not produced at all. So when flushing, we should only keep the type if we have a heeftBestuursfunctie predicate on the orgaan. This is just a supposition, to be tested!
...plestore/2025/20250221050000-flush-leidingevenden-triples-in-favour-of-op-public-sync.sparql
Outdated
Show resolved
Hide resolved
| WHERE { | ||
| GRAPH <http://redpencil.data.gift/id/deltas/producer/loket-leidinggevenden-producer> { | ||
| ?s | ||
| rfd:type <http://data.vlaanderen.be/ns/besluit#Bestuursorgaan> ; |
...plestore/2025/20250221050000-flush-leidingevenden-triples-in-favour-of-op-public-sync.sparql
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DL-6449]
See #638
The notes that would come in this description would be almost identical to the ones in the linked PR above from @claire-lovisa. Please use those notes and apply them to the
app-leidingevenden-databank.NOTE: I copied what @claire-lovisa did in their PR, but applied those changes to leidinggevenden.
NOTE: I found some predicates that seem to be added in Loket on the
BestuursorgaanandBestuursfunctie. See the migration on the publication triplestore, where I attempt to keep them. I assume these are important.TODO: I would like to still run a test, such as in the aforementioned PR to see if all runs well.