Update to latest ember-appuniversum v3.4.1 #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
changed the title
piemonkey
force-pushed
the
internal/latest-au-icons
branch
from
f786f93 to
802479c
Compare
piemonkey
force-pushed
the
internal/latest-au-icons
branch
2 times, most recently
from
d830106 to
165f706
Compare
Enables support for older versions of ember-appuniversum on platforms that do not need inline svg icons
piemonkey
force-pushed
the
internal/latest-au-icons
branch
from
165f706 to
627dc56
Compare
elpoelma
requested changes
Mar 29, 2024
elpoelma
reviewed
Mar 29, 2024
The test app uses 2.17.0 as this allows us to use the new scss import paths. 2.15.0 is supported if the client app imports the scss from the old paths. That makes this set of changes non-breaking.
Co-authored-by: Elena Poelman <elena.poelman@redpencil.io>
elpoelma
approved these changes
Mar 29, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Passing icons as components instead of strings, as this uses inline SVGs rather than making an extra request for an svgiconset which fails on embeddable.
This allows and requires the latest ember-appuniversum, 3.4.1, as without that, the passing of components to
@iconarguments will fail. Any usage of icons using astringargument will result in the svgiconset version being used, which will fail on embeddable.In order to support importing icons in template only components, added support for
.gtssingle file templates and updated the tooling to add better type checking supported by these.connected issues and PRs:
Part of lblod/frontend-embeddable-notule-editor#243
Uses the work on appuniversum/ember-appuniversum#482
Setup
You might need to do some set-up in your editor if you haven't set it up to support the new template syntax, details in the ember docs for highlighting and the glint docs for type checking.
In order to test with the new icons imports, you'll need to change the appuniversum version in the test app to
3.4.1.How to test/reproduce
All the icons should work. If you inspect an icon, you should no longer see a
<use>element inside the<svg>, you should just see the svg inline.Challenges/uncertainties
While refactoring it was easier to write macros that relied on
'quotes being used instead of optionally supporting", so I converted them. This results in more consistency between files anyway.There's a bug with some of the new icon components, noted here which I have worked around rather than waiting for a new AU release.This is now fixed in 3.4.1 of AU.Checks PR readiness