-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mypy executable is reported missing despite successful test #98
Comments
Yep, sorry, this is a use case that is not supported by the plugin currently. You coud probably make it work with some hacks -- like creating a wrapper script named |
I dug into the code. Looks like the initial issue is in the way how availability is checked, see here. When files are being added for scanning that function is called with |
I am observing another issue, which I am unsure if it is related or not. I now managed to run mypy, I see in the code that it returns 14 issues, but they are not displayed in the UI. UI indicates |
* Function checkMypyAvailable is called from various places in the code. If user specifies a custom mypy executable, which is not part of project's venv, then this function will return false when called with showNotifications == true. This happens because the function checks for mypy presence in the project's venv and it doesn't respect the custom path. This change makes the function check for mypy in the project's venv only if no custom path is present. * Additional note. It may be better to check for mypy presence in the current venv after isMypyPathValid call. Thus, a user would get two notifications: mypy is not available, click here to install it. Fixes leinardi#98
Step 1: Are you in the right place?
Step 2: Describe your environment
0.14.0
2021.3.1
0.780
Step 3: Describe the problem:
Steps to reproduce:
Test
button.Check current button
Observed Results:
Mypy found no problems
mypy missing
.Expected Results:
Relevant Code:
The text was updated successfully, but these errors were encountered: