Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refont of confirmation page when you enable subscription - Add images #1110

Open
Tracked by #1115
Kevils opened this issue Feb 28, 2025 · 3 comments
Open
Tracked by #1115

Refont of confirmation page when you enable subscription - Add images #1110

Kevils opened this issue Feb 28, 2025 · 3 comments

Comments

@Kevils
Copy link
Collaborator

Kevils commented Feb 28, 2025

Description 📹

Current :
Image

New design :
Image

Figma : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=7022-31922&t=XCt8XQUo4vZRtmIv-1

Today, we have a popup that appears to confirm the activation of the subscription. We can replace this popup with a full page that we already use as confirmation. Add images. Just do that, the other content to add to the page is in other issues.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution and removed Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution labels Feb 28, 2025
@legend4tech
Copy link

Hi, I'm excited to contribute to this project. I have strong experience in Next.js, React, TypeScript, JavaScript, MongoDB, ShadCN, Redux, and React Query. Let me know how I can help! Looking forward to collaborating

@Marvelousmicheal
Copy link
Contributor

Is it okay if I tackle this?

@cryptogru812
Copy link
Contributor

Can I contribute to this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants