Fix the weight of first section #1032

supreme2580 · 2025-02-08T14:54:05Z

Added a 1440px constraint to /pages/index.tsx by updating /styles/Home.module.css from

.screen {
  height: 88vh;
  position: relative;
  margin-top: 12vh;
  overflow: auto;
}

.wrapperScreen {
  display: inline-flex;
  flex-direction: column;
  width: 100%;
  justify-content: center;
  height: calc(100% - 12vh);
}

to

.screen {
  height: 88vh;
  position: relative;
  margin-top: 12vh;
  overflow: auto;
  display: flex;
  justify-content: center;
}

.wrapperScreen {
  display: inline-flex;
  flex-direction: column;
  width: 100%;
  max-width: 1440px;
  margin: 0 auto;
  justify-content: center;
  height: calc(100% - 12vh);
}

Summary by CodeRabbit

Style
- Enhanced the homepage layout for improved responsiveness.
- Child elements are now centered horizontally for a cleaner design.
- The main container’s width is confined and centrally positioned for better visual structure.

…ule.css

vercel · 2025-02-08T14:54:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 8, 2025 2:56pm

coderabbitai · 2025-02-08T14:54:11Z

Walkthrough

This pull request updates the layout in the Home.module.css file. The .screen class now utilizes flexbox with centered justification for its children, while the .wrapperScreen class is modified to have a fixed maximum width of 1440px and centered margins. These changes adjust the content alignment and constrain its width for larger screens.

Changes

File	Change Summary
styles/Home.module.css	• .screen: added display: flex; justify-content: center; • .wrapperScreen: added max-width: 1440px; margin: 0 auto;

Assessment against linked issues

Objective	Addressed	Explanation
Fix the weight of first section (#1017)	✅

Possibly related PRs

fix: global style #1010: Adjustments to layout in Home.module.css with similar changes affecting height and overall component structure.

Suggested labels

🔥 Ready for review

Suggested reviewers

Marchand-Nicolas

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc0a63a and 5024c0b.

📒 Files selected for processing (1)

styles/Home.module.css (1 hunks)

🔇 Additional comments (2)

styles/Home.module.css (2)

6-7: Enhance Flex Container for Centering Child Elements

Adding "display: flex;" and "justify-content: center;" to the .screen class helps ensure that its child elements are centered horizontally. This change aligns with the overall objective of improving layout presentation.

14-15: Enforce Width Constraint and Center the Wrapper

Introducing "max-width: 1440px;" along with "margin: 0 auto;" in the .wrapperScreen class effectively constrains its width to the desired maximum and centers it within its parent container. This adjustment meets the PR objective of applying a 1440px width and enhances the overall layout consistency.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-02-08T14:54:12Z

@supreme2580 is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

supreme2580 · 2025-02-08T15:23:25Z

@Kevils Hi I am unable to set labels to "ready for review" but it is ready for review

supreme2580 · 2025-02-08T18:46:31Z

also @Kevils does first section mean the header should be constrained 1440px or did you mean the body? (because I wrapped the body to fit a max width of 1440px)

Marchand-Nicolas

As written in the issue, please add close: #<issueNumber> to your PR's description. Else I don't know what is your PR for

supreme2580 · 2025-02-10T16:26:32Z

As written in the issue, please add close: #<issueNumber> to your PR's description. Else I don't know what is your PR for

Hi @Marchand-Nicolas I've changed it from 'closes' to 'close'

Marchand-Nicolas · 2025-02-11T11:54:03Z

Thanks, didn't see the previous one because it was at the end of the desc sorry

supreme2580 · 2025-02-11T11:55:14Z

No problem boss, thank you

…

On Tue, Feb 11, 2025 at 12:54 PM Nico ***@***.***> wrote: Thanks, didn't see the previous one because it was at the end of the desc sorry — Reply to this email directly, view it on GitHub <#1032 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYAQUBMGHOBN3KP3QVPJK3L2PHQHFAVCNFSM6AAAAABWXYRV2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJQGU4DOMRSGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Marchand-Nicolas

Perfect lgtm!

Fix: added a 1440px constraint on the wrapperScreen style of home.mod…

5024c0b

…ule.css

vercel bot deployed to Preview – app-starknet-id February 8, 2025 14:56 View deployment

Marchand-Nicolas requested changes Feb 10, 2025

View reviewed changes

Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Feb 10, 2025

supreme2580 requested a review from Marchand-Nicolas February 10, 2025 17:29

Marchand-Nicolas approved these changes Feb 11, 2025

View reviewed changes

Marchand-Nicolas merged commit 40d1083 into lfglabs-dev:testnet Feb 11, 2025
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the weight of first section #1032

Fix the weight of first section #1032

supreme2580 commented Feb 8, 2025 •

edited

Loading

vercel bot commented Feb 8, 2025 •

edited

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

vercel bot commented Feb 8, 2025

supreme2580 commented Feb 8, 2025 •

edited

Loading

supreme2580 commented Feb 8, 2025

Marchand-Nicolas left a comment

supreme2580 commented Feb 10, 2025 •

edited

Loading

Marchand-Nicolas commented Feb 11, 2025

supreme2580 commented Feb 11, 2025 via email

Marchand-Nicolas left a comment

Fix the weight of first section #1032

Fix the weight of first section #1032

Conversation

supreme2580 commented Feb 8, 2025 • edited Loading

Summary by CodeRabbit

vercel bot commented Feb 8, 2025 • edited Loading

coderabbitai bot commented Feb 8, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vercel bot commented Feb 8, 2025

supreme2580 commented Feb 8, 2025 • edited Loading

supreme2580 commented Feb 8, 2025

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

supreme2580 commented Feb 10, 2025 • edited Loading

Marchand-Nicolas commented Feb 11, 2025

supreme2580 commented Feb 11, 2025 via email

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

supreme2580 commented Feb 8, 2025 •

edited

Loading

vercel bot commented Feb 8, 2025 •

edited

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

supreme2580 commented Feb 8, 2025 •

edited

Loading

supreme2580 commented Feb 10, 2025 •

edited

Loading