fix: paymaster problems #957
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marchand-Nicolas
added
the
🚧 In progress do not merge
WalkthroughThe pull request modifies the Changes
Sequence DiagramsequenceDiagram
participant Caller
participant getFreeRegistrationCalls
participant Contract
Caller->>getFreeRegistrationCalls: Call with parameters
getFreeRegistrationCalls->>getFreeRegistrationCalls: Convert txMetadataHash
Note over getFreeRegistrationCalls: hexToDecimal(txMetadataHash)
Note over getFreeRegistrationCalls: numberToStringHex(decimalValue)
getFreeRegistrationCalls->>Contract: Prepare calldata with processed txMetadataHash
The sequence diagram illustrates the transformation of 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
utils/callData/registrationCalls.ts (1)
Line range hint
229-240: Well-structured parameter formatting pattern for contract interactions.The function demonstrates a consistent architectural pattern for parameter formatting in contract interactions:
- Domain parameters use
numberToStringHex- Signatures are mapped with
numberToStringHex- Metadata hash now follows the same pattern
This consistency improves maintainability and reduces the likelihood of parameter formatting mismatches.
Consider documenting this parameter formatting pattern in the codebase to ensure future contract interactions follow the same approach.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
utils/callData/registrationCalls.ts(1 hunks)
🔇 Additional comments (1)
utils/callData/registrationCalls.ts (1)
237-237: LGTM! The metadata hash conversion aligns with parameter formatting pattern.
The change improves consistency by ensuring the metadata hash follows the same formatting pattern as other parameters in the calldata array (using numberToStringHex). This alignment with the established pattern likely resolves the paymaster issues.
Let's verify the consistency of metadata handling across the codebase:
✅ Verification successful
The metadata hash conversion is correctly implemented and consistent with the codebase patterns
Based on the codebase analysis, the change to wrap hexToDecimal(txMetadataHash) with numberToStringHex is verified to be correct for the following reasons:
-
The pattern of converting metadata hashes using
hexToDecimalis consistently used across the codebase for contract interactions, as seen in multiple files:utils/callData/registrationCalls.tsutils/callData/autoRenewalCalls.ts- Components like
registerDiscount.tsx,freeRegisterCheckout.tsx
-
The
numberToStringHexconversion is commonly used for formatting parameters in contract calls, particularly in registration and renewal functions, ensuring consistent parameter formatting. -
The change aligns with how other metadata hashes are processed in similar contract interactions throughout the codebase, maintaining consistency in how contract parameters are formatted.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other instances of metadata hash processing in contract calls
# to confirm this change aligns with the established pattern
ast-grep --pattern 'hexToDecimal($hash)'
# Also check for similar parameter processing patterns
ast-grep --pattern 'numberToStringHex($param)'
Length of output: 91
Script:
#!/bin/bash
# Let's try a broader search for hexToDecimal and numberToStringHex usage
rg "hexToDecimal|numberToStringHex" -A 2 -B 2
# Also search for metadata hash handling patterns
rg "metadataHash" -A 2 -B 2
Length of output: 40905
Marchand-Nicolas
added
🔥 Ready for review
* Fix: Add distinct warning for expired domains * Fix: Add distinct warning for expired domains * Fix: Add distinct warning for expired domains * Fix: Add distinct warning for expired domains * add distinct warning for expired domains * expiring soon checks if enbaled auto renewal * removing space * fix: paymaster problems (#957) * fix: paymaster problems * add comment --------- Co-authored-by: Aroso Emmanuel <emmanueladedejiaroso@gmail.com> Co-authored-by: Aroso Emmanuel Adedeji <57766083+emarc99@users.noreply.github.com>
Summary by CodeRabbit