fix: add similar to starknetjs

lfglabs-dev · Jan 27, 2025 · 85692ff · 85692ff
1 parent 674dba0
commit 85692ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/core/__test__/default.test.ts b/packages/core/__test__/default.test.ts
@@ -236,7 +236,7 @@ describe("test starknetid.js sdk", () => {
     expect(starknetIdNavigator).toBeInstanceOf(StarknetIdNavigator);
     await expect(
       starknetIdNavigator.getAddressFromStarkName("test.eth"),
-    ).rejects.toThrow("Domain is not a .stark domain");
+    ).rejects.toThrow("Invalid domain, must be a valid .stark domain");
   });
 
   test("getStarkName should fail because address has no starkname", async () => {

diff --git a/packages/core/src/starknetIdNavigator/default.ts b/packages/core/src/starknetIdNavigator/default.ts
@@ -52,8 +52,10 @@ export class StarknetIdNavigator implements StarknetIdNavigatorInterface {
   }
 
   public async getAddressFromStarkName(domain: string): Promise<string> {
-    if (!isStarkDomain(domain)) {
-      throw new Error("Domain is not a .stark domain");
+    const starkName = domain.endsWith(".stark") ? domain : `${domain}.stark`;
+
+    if (!isStarkDomain(starkName)) {
+      throw new Error("Invalid domain, must be a valid .stark domain");
     }
 
     const contract =