-
-
Notifications
You must be signed in to change notification settings - Fork 483
feat: remove legacy subscription view #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Drops the legacy subscription view, which was marked as legacy ~3 years ago. Given the long time, lack of updates since, it should be safe to remove. This further reduces the amount of 'unnecessary' options. Ref: libre-tube#7276 Ref: libre-tube@298023b Closes: libre-tube#7403
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is a good step, but since this option has probably been used by tablet users mostly, we should think about improving the default subscriptions view for large screens (e.g. respecting the grid column preference and putting multiple channels in a row). Otherwise with tablets in landscape, you only have the channel avarar + name at the left and then a lot of blank space until the subscribe button.
Maybe we could rethink the design and use bottom sheet instead? That way the current design would work on most screen sizes. |
I don't mind rethinking the design, but wouldn't a bottom sheet just make it more complicated to browse the subcriptions? Although it coiluld for instance allow us to add a search feature for subscribed channels (like in the channel groups menu), so that could be nice too. |
Drops the legacy subscription view, which was marked as legacy ~3 years ago. Given the long time, lack of updates since, it should be safe to remove. This further reduces the amount of 'unnecessary' options.
Ref: #7276
Ref: 298023b
Closes: #7403