AddPulseAudioDevice(): Fix use-after-free

Sackzement · slouken · commit 6aef6ae9a801 · 2025-02-17T11:12:44.000-08:00
diff --git a/src/audio/pulseaudio/SDL_pulseaudio.c b/src/audio/pulseaudio/SDL_pulseaudio.c
@@ -778,8 +778,8 @@ static void AddPulseAudioDevice(const bool recording, const char *description, c
             SDL_free(handle);
         } else {
             handle->device_index = index;
+            SDL_AddAudioDevice(recording, description, &spec, handle);
         }
-        SDL_AddAudioDevice(recording, description, &spec, handle);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -778,8 +778,8 @@ static void AddPulseAudioDevice(const bool recording, const char *description, c`
`778`	`778`	`SDL_free(handle);`
`779`	`779`	`} else {`
`780`	`780`	`handle->device_index = index;`
	`781`	`+ SDL_AddAudioDevice(recording, description, &spec, handle);`
`781`	`782`	`}`
`782`		`- SDL_AddAudioDevice(recording, description, &spec, handle);`
`783`	`783`	`}`
`784`	`784`	`}`
`785`	`785`