Fixed crash if trying to dump a packet larger than USB_PACKET_LENGTH

slouken · slouken · commit a910b98209d2 · 2023-05-25T12:44:28.000-07:00
diff --git a/src/joystick/hidapi/SDL_hidapijoystick.c b/src/joystick/hidapi/SDL_hidapijoystick.c
@@ -117,7 +117,7 @@ void HIDAPI_DumpPacket(const char *prefix, const Uint8 *data, int size)
 {
     int i;
     char *buffer;
-    size_t length = SDL_strlen(prefix) + 11 * (USB_PACKET_LENGTH / 8) + (5 * USB_PACKET_LENGTH * 2) + 1 + 1;
+    size_t length = SDL_strlen(prefix) + 11 * (size / 8) + (5 * size * 2) + 1 + 1;
     int start = 0, amount = size;
     size_t current_len;
 

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ void HIDAPI_DumpPacket(const char prefix, const Uint8 data, int size)`
`117`	`117`	`{`
`118`	`118`	`int i;`
`119`	`119`	`char *buffer;`
`120`		`- size_t length = SDL_strlen(prefix) + 11 * (USB_PACKET_LENGTH / 8) + (5 * USB_PACKET_LENGTH * 2) + 1 + 1;`
	`120`	`+ size_t length = SDL_strlen(prefix) + 11 * (size / 8) + (5 * size * 2) + 1 + 1;`
`121`	`121`	`int start = 0, amount = size;`
`122`	`122`	`size_t current_len;`
`123`	`123`