Skip to content

hidapi: commits from mainstream for mac and windows #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sezero opened this issue May 22, 2023 · 4 comments · Fixed by #7736
Closed

hidapi: commits from mainstream for mac and windows #7727

sezero opened this issue May 22, 2023 · 4 comments · Fixed by #7736
Assignees
@slouken
Milestone
3.2.0

Comments

@sezero
Copy link
Contributor

sezero commented May 22, 2023

@slouken: These might - or might not - be of interest for backporting into SDL?
Just FYI...

Windows: libusb/hidapi#464
libusb/hidapi@bd6be4d

Mac: libusb/hidapi#531
libusb/hidapi#534
libusb/hidapi@80a206a
libusb/hidapi@b516e97
@slouken
Copy link
Collaborator

slouken commented May 22, 2023

I wonder if it's time to rebase SDL's hidapi on the latest upstream code?

@slouken slouken added this to the 3.2.0 milestone May 22, 2023
@sezero
Copy link
Contributor Author

sezero commented May 22, 2023

For SDL3 only, I guess

@slouken
Copy link
Collaborator

slouken commented May 22, 2023

Yep, if we're going to update the API now's a good time. I know we've added some good fixes as well, and it would be nice to be able to upstream them.

@slouken slouken mentioned this issue May 24, 2023
Merged
@slouken slouken self-assigned this May 24, 2023
@slouken
Copy link
Collaborator

slouken commented May 26, 2023 •
edited
Loading

So that was a fair bit of work, but we're now rebased on upstream and I think we have all the important changes for SDL. I merged the PR for additional testing and I'll go ahead and start some PRs so we can get them upstreamed as desired by the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slouken slouken

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Update HIDAPI to match upstream hidapi 0.14.0 slouken/SDL
2 participants
@slouken @sezero