[SDL3] Adding input and FFB support for Logitech G29(PS3) on hidapi #11598

Kethen · 2024-12-06T16:58:24Z

#11591 for SDL3

companion test program for SDL3 https://github.com/Kethen/sdl_lg4ff_util/tree/SDL3_lg4ff

WINE has not moved onto SDL3 so it cannot be tried on WINE at the moment

Xcode/SDL/SDL.xcodeproj/project.pbxproj

slouken · 2024-12-06T18:04:17Z

This is an impressive PR. How does this interact with other drivers, like new-lg4ff? Is there any reason we'd want this active when those are available?

Kethen · 2024-12-06T19:46:59Z

This is an impressive PR.

Thanks but a large portion of it was ported from https://github.com/berarma/new-lg4ff

How does this interact with other drivers, like new-lg4ff?

On Linux, it depends on how it was opened:

If it was opened on /dev/hidraw*, kernel drivers would stay active, and if the wheel is accessed through both drivers, it will be receiving confusing commands from two sources, tho it's generally fine if active effects are on only one side at a time
If it was opened on /dev/bus/usb/* using libusb, exclusive access should be obtained and kernel drivers will unprobe

Which path would happen depends on which hidapi backend SDL was built to use and device node permissions

On MacOS, if I understand correctly some games also use IOHIDManager to provide wheel support on their own. SDL3 currently does not grab exclusive access

SDL/src/hidapi/SDL_hidapi.c

Line 1246 in 4742922

hid_darwin_set_open_exclusive(0);

No idea if existing games grab exclusive access

On Windows, I have no idea how it would react with the Logitech driver, no idea if any exclusive access would happen when hidapi opens the device from CM_Get_Device_Interface_List fetched interface names

Is there any reason we'd want this active when those are available?

On Linux, evdev does not provide an analog to GetEffectStatus, user is expected to track that as effects are uploaded, I think https://bugzilla.kernel.org/show_bug.cgi?id=219189; otherwise I'd expect the kernel drivers to have better latency profiles

As for availability, unless udev rules were supplied (usb) (hidraw), the evdev backend would be used on SDL

On Windows, once again I have no idea

Kethen · 2024-12-06T23:21:21Z

Added build fixes for platforms with hidapi disabled, without M_PI, and Android

Still need help with MSVC project files

Kethen · 2024-12-07T12:40:43Z

rebased and fixed windows building

slime73 · 2024-12-07T16:51:26Z

a large portion of it was ported from https://github.com/berarma/new-lg4ff

If code was taken from there, is there permission to relicense it from GPL to zlib?

src/haptic/hidapi/SDL_hidapihaptic_lg4ff.c

Kethen · 2025-01-15T12:18:34Z

Thanks @mungewell , @MadCatX and @berarma once again for graciously allowing ported code to be used under Zlib license in SDL

#11591 (comment)
#11591 (comment)

Lawstorant · 2025-02-26T16:16:08Z

WINE has not moved onto SDL3 so it cannot be tried on WINE at the moment

What about sdl2-compat? I've been using it lately as arch forced this move and it works great. It should allow you to test this with Wine.

slouken · 2025-03-02T16:01:50Z

src/joystick/SDL_gamepad.c

@@ -2574,7 +2574,12 @@ bool SDL_IsGamepad(SDL_JoystickID instance_id)
    SDL_LockJoysticks();
    {
        const void *value;
-        if (SDL_FindInHashTable(s_gamepadInstanceIDs, (void *)(uintptr_t)instance_id, &value)) {
+        SDL_JoystickType js_type = SDL_GetJoystickTypeForID(instance_id);


You probably want this logic in the else case so you can cache the value and not call this every time the function is called.

yeah that would make more sense, sorry for not understanding the result caching before

Current implementation does not include SDL_Haptic integration for force feedback Supported devices: G29, G27, G25, DFGT, DFP Features: Joystick button, hat and axis input 5 level rev light control on SDL_JoystickSetLED raw hid command sending on SDL_JoystickSendEffect all command sending are based on https://github.com/berarma/new-lg4ff tested on G29 in various compat modes shifter input is not tested because I don't have one

effect rendering is ported from https://github.com/berarma/new-lg4ff

If a SDL_Joystick internal lookup manages to define a joystick type that is not gamepad, it should stay as a joystick

…d, SDL_SetHapticGain and SDL_SetHapticAutocenter sequence

Original commit: Author: Ozkan Sezer <sezeroz@gmail.com> Date: Sun Dec 29 17:55:04 2024 +0300 minor clean-ups: - make _abs,_llabs, get_time_ms, effect_is_periodic, effect_is_condition helpers static inline. - rename _abs and _llabs to abs32 and abs64 to avoid analyzers complain about reserved names. - make the drivers[] array static. - NULL terminate the drivers[] array to avoid an empty array in case if SDL_HAPTIC_HIDAPI_LG4FF isn't configured. - minor formatting clean-ups here and there. - remove #endif comments about SDL_JOYSTICK_HIDAPI for readability. those #if / #endif blocks are short enough already.

…cense year

Kethen · 2025-03-12T10:05:00Z

WINE has not moved onto SDL3 so it cannot be tried on WINE at the moment

What about sdl2-compat? I've been using it lately as arch forced this move and it works great. It should allow you to test this with Wine.

tested that a while back and it didn't quite work in WINE, it just didn't enumerate controllers, and I haven't gotten around to figure out why it didn't work

sdl2-compat does work with the companion test program however last time I tried

slouken · 2025-03-14T16:33:49Z

WINE has not moved onto SDL3 so it cannot be tried on WINE at the moment

What about sdl2-compat? I've been using it lately as arch forced this move and it works great. It should allow you to test this with Wine.

tested that a while back and it didn't quite work in WINE, it just didn't enumerate controllers, and I haven't gotten around to figure out why it didn't work

Can you investigate this? I'm ready to merge once it's confirmed working.

Kethen · 2025-03-17T13:16:43Z

WINE has not moved onto SDL3 so it cannot be tried on WINE at the moment

What about sdl2-compat? I've been using it lately as arch forced this move and it works great. It should allow you to test this with Wine.

tested that a while back and it didn't quite work in WINE, it just didn't enumerate controllers, and I haven't gotten around to figure out why it didn't work

Can you investigate this? I'm ready to merge once it's confirmed working.

Just gave it a test, as of writing, on Linux, freshly compiled sdl2-compat(4453e2d05881c3616af8ca71f7c4267c60f993d8) can enumerate controllers in wine (10.0 staging and GE-Proton9-25), and can be used with this PR to provide G29 ffb for assetto corsa on dinput8, with the appropriate udev rules

$ lsusb
...
Bus 001 Device 016: ID 046d:c24f Logitech, Inc. G29 Driving Force Racing Wheel [PS3]
...

$ WINEDEBUG="-all,+hid" LD_LIBRARY_PATH="$(realpath ./sdl_test)" wine ... 2>&1 | tee log.txt &
$ cat log.txt
...
0098:trace:hid:process_device_event Received action 605
0098:trace:hid:sdl_add_device Making up serial number for Logitech G29: 03009a206d0400004fc2000000646800.0
0098:trace:hid:sdl_add_device joystick id 0, axis_offset 0, desc {vid 046d, pid c24f, version 6400, input -1, uid 00000000, is_gamepad 0}.
...
0084:trace:hid:sdl_device_physical_device_control iface 0x7fb14802fe40, control 0x9a.
0084:trace:hid:sdl_device_physical_device_set_gain iface 0x7fb14802fe40, percent 0x64.
0084:trace:hid:sdl_device_physical_effect_update iface 0x7fb14802fe40, index 1, params 0x7fb14802ffe0.
...

$ lsof /dev/bus/usb/001/016 sdl_test/*
lsof: WARNING: can't stat() tracefs file system /sys/kernel/debug/tracing
      Output information may be incomplete.
COMMAND     PID      USER  FD   TYPE DEVICE SIZE/OFF    NODE NAME
winedevic 89380 katharine mem    REG   0,52          3975143 sdl_test/libSDL3.so.0 (stat: Operation not permitted)
winedevic 89380 katharine mem    REG   0,52          3975144 sdl_test/libSDL2-2.0.so.0 (stat: Operation not permitted)
winedevic 89380 katharine  43u   CHR 189,15      0t0    1176 /dev/bus/usb/001/016
winedevic 89380 katharine  51u   CHR 189,15      0t0    1176 /dev/bus/usb/001/016

slouken · 2025-03-17T14:25:05Z

Great! This is merged, thank you for all your work!

Kethen mentioned this pull request Dec 6, 2024

[SDL2] Adding input and FFB support for Logitech G29(PS3) on hidapi #11591

Closed

slouken reviewed Dec 6, 2024

View reviewed changes

Xcode/SDL/SDL.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

Kethen force-pushed the SDL3_lg4ff branch from aff4f81 to d6cc30f Compare December 6, 2024 19:01

Kethen force-pushed the SDL3_lg4ff branch from 3692c70 to e0e4531 Compare December 6, 2024 22:08

Kethen force-pushed the SDL3_lg4ff branch 4 times, most recently from f3c2dcc to c59ecbc Compare December 7, 2024 11:09

Kethen force-pushed the SDL3_lg4ff branch 2 times, most recently from 8857b97 to 7d16076 Compare December 29, 2024 12:28

sezero reviewed Dec 29, 2024

View reviewed changes

src/haptic/hidapi/SDL_hidapihaptic_lg4ff.c Outdated Show resolved Hide resolved

Kethen force-pushed the SDL3_lg4ff branch from d0101e7 to 6a9788b Compare December 29, 2024 16:20

slouken added this to the 3.4.0 milestone Jan 15, 2025

Kethen force-pushed the SDL3_lg4ff branch from 90c4dff to e3ab06a Compare January 16, 2025 21:39

slouken reviewed Mar 2, 2025

View reviewed changes

Kethen and others added 8 commits March 12, 2025 10:50

Add hidapi SDL_Haptic carrier and SDL_Haptic lg4ff implementation

72d50cc

effect rendering is ported from https://github.com/berarma/new-lg4ff

Do not spawn SDL_Gamepad mapping on known hidapi devices

74b48ab

If a SDL_Joystick internal lookup manages to define a joystick type that is not gamepad, it should stay as a joystick

rewind objectVersion in xcode project file

5cf5f62

fix haiku building

5c1cdf3

fix build on non-hidapi platforms

f3a143a

fix build on platforms without MPI

145ea0a

fix build on android

1ffb622

Kethen and others added 17 commits March 12, 2025 10:50

fix cmake msvc build

31556bb

fix SDL_OpenHaptic and SDL_OpenHapticFromJoystick's SDL_SetObjectVali…

6417742

…d, SDL_SetHapticGain and SDL_SetHapticAutocenter sequence

hand fixing VC project files, more build fixes

4cf000b

cleanup, label ported code on a per function basis

928b822

report led cap

2f71e95

native mode switch

b63612d

do not touch SDL_Joystick ref_count from SDL_hidapihaptic.c

0ee5cba

send ffex autocenter command when identified

87c2507

fix building on platforms without abs and llabs

ceab2c6

fix building on platforms without sin

dfdbadd

adjust dfp input when custom range is applied

df68349

destory mutex when closing lg4ff hidapihaptic

6e60960

fix SDL_hid_read return container

9671105

fix env name for adjusting lg4ff damper effect gain

66e8ad5

add copyrights of authors of ported code to license header, update li…

3e14e48

…cense year

fix windows ci builds

912781d

Kethen force-pushed the SDL3_lg4ff branch from e3ab06a to ed715e1 Compare March 12, 2025 10:01

SDL_IsGamepad cache verdict obtained from joystick type check

a031422

Kethen force-pushed the SDL3_lg4ff branch from ed715e1 to a031422 Compare March 12, 2025 10:07

slouken merged commit 35c0377 into libsdl-org:main Mar 17, 2025
39 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDL3] Adding input and FFB support for Logitech G29(PS3) on hidapi #11598

[SDL3] Adding input and FFB support for Logitech G29(PS3) on hidapi #11598

Uh oh!

Kethen commented Dec 6, 2024

Uh oh!

Uh oh!

slouken commented Dec 6, 2024

Uh oh!

Kethen commented Dec 6, 2024

Uh oh!

Kethen commented Dec 6, 2024 •

edited

Loading

Uh oh!

Kethen commented Dec 7, 2024

Uh oh!

slime73 commented Dec 7, 2024

Uh oh!

Uh oh!

Kethen commented Jan 15, 2025

Uh oh!

Lawstorant commented Feb 26, 2025 •

edited

Loading

Uh oh!

slouken Mar 2, 2025

Uh oh!

Kethen Mar 12, 2025

Uh oh!

Kethen commented Mar 12, 2025

Uh oh!

slouken commented Mar 14, 2025

Uh oh!

Kethen commented Mar 17, 2025

Uh oh!

Uh oh!

slouken commented Mar 17, 2025

Uh oh!

Uh oh!

[SDL3] Adding input and FFB support for Logitech G29(PS3) on hidapi #11598

[SDL3] Adding input and FFB support for Logitech G29(PS3) on hidapi #11598

Uh oh!

Conversation

Kethen commented Dec 6, 2024

Uh oh!

Uh oh!

slouken commented Dec 6, 2024

Uh oh!

Kethen commented Dec 6, 2024

Uh oh!

Kethen commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kethen commented Dec 7, 2024

Uh oh!

slime73 commented Dec 7, 2024

Uh oh!

Uh oh!

Kethen commented Jan 15, 2025

Uh oh!

Lawstorant commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slouken Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

Kethen Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Kethen commented Mar 12, 2025

Uh oh!

slouken commented Mar 14, 2025

Uh oh!

Kethen commented Mar 17, 2025

Uh oh!

Uh oh!

slouken commented Mar 17, 2025

Uh oh!

Uh oh!

Kethen commented Dec 6, 2024 •

edited

Loading

Lawstorant commented Feb 26, 2025 •

edited

Loading