Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't seem much discussion about whether those dialogs should be added to SDL; I open this PR also as a discussion as to whether or not they should be, and which ones are relevant to SDL. I presumed it would be easier to discuss with working code available.
Description
This PR adds the following input dialogs types:
These also seem to be available, but I'm not sure if they're globally useful:
As of opening the PR, only the Zenity implementation is supported. I chose to open this PR early to get feedback on the current API.
Should I add the two remaining dialog types? More generally, which ones are good to add in SDL?
If some would be good to add:
SDL_PropertiesID
argument; should I make a simple version for each, similarly toSDL_ShowSimpleMessageBox
?SDL_PROP_DIALOG_TITLE_STRING
for all dialogs)I should be able to take care of the Windows implementation, but I haven't yet gotten my hands on a new macOS device; help would be welcome.
Existing Issue(s)
Fixes #12792