cmake: don't force enable/disable SDL_HIDAPI_LIBUSB #7754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CMakeDependentOption instead to configure SDL_HIDAPI_LIBUSB to a okay-ish variable.
sezero
reviewed
May 28, 2023
| @@ -167,17 +167,17 @@ endif() | |||
| # so we default to yes on iOS. | |||
| # TODO: Windows can support libusb, the hid.c file just depends on Unix APIs | |||
| if((WINDOWS AND NOT WINDOWS_STORE) OR IOS OR TVOS OR ANDROID) | |||
There was a problem hiding this comment.
Is NOT WINDOWS_STORE here is a product of copy & paste or do we really support UWP with libusb?
There was a problem hiding this comment.
I'm not sure if libusb works on UWP, but our libusb support does work on Windows. I tested it this week.
There was a problem hiding this comment.
This part of the cmake'ry needs revision, then. As for windows, is the native driver not good enough?
There was a problem hiding this comment.
The Windows libusb is definitely quirky and if we change this, we shouldn't enable it by default. For example, sending some reports to a DualSense controller will hang for a full second - and it doesn't do that on any other hidapi backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CMakeDependentOption instead to configure SDL_HIDAPI_LIBUSB to a okay-ish variable.
Description
By not forcing the variable, it should be possible to disable
SDL_HIDAPI_LIBUSB.Existing Issue(s)
#7736