Skip to content

struct SDL_hid_device_info incompatibility #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sezero opened this issue May 27, 2023 · 5 comments
Closed

struct SDL_hid_device_info incompatibility #76

sezero opened this issue May 27, 2023 · 5 comments

Comments

@sezero
Copy link
Contributor

sezero commented May 27, 2023

          We have a new SDL2 incompatibility: `struct SDL_hid_device_info` has
          got inserted a new `bus_type` member. The structure is public, at it
          is a parameter to `SDL_hid_enumerate` and `SDL_hid_free_enumeration`.
          sdl2-compat still wrongly does passthrough for those: Needs taking
          care of.

Originally posted by @sezero in libsdl-org/SDL#7736 (comment)

CC: @slouken

@slouken
Copy link
Collaborator

slouken commented May 27, 2023

Good point. I can move the bus_type member to the end, to preserve compatibility.

@sezero
Copy link
Contributor Author

sezero commented May 28, 2023

Good point. I can move the bus_type member to the end, to preserve compatibility.

Yes, that'd be a solution.

@slouken
Copy link
Collaborator

slouken commented May 28, 2023

Actually, the structure looks nicer the way it is. @icculus, what do you think about preferring SDL 3.0 aesthetics over sdl2-compat passthrough ability?

@icculus
Copy link
Collaborator

icculus commented May 28, 2023

It's not a big surface area, we can manage it in sdl2-compat.

@icculus
Copy link
Collaborator

icculus commented May 28, 2023

Fixed in 1f34831.

@icculus icculus closed this as completed May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants