🚨 [experiment] signals unwatch (issue) v2

.github/workflows/perf.yml

@@ -5,8 +5,9 @@ on:
   push:
     branches:
       - master
+      - check-signals
   pull_request:
-    branches: [master]
+    branches: [master, check-signals]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}

package.json

@@ -104,6 +104,6 @@
     "@glimmer/syntax": "^0.87.1",
     "content-tag": "^1.2.2",
     "decorator-transforms": "1.1.0",
-    "signal-polyfill": "^0.1.0"
+    "signal-polyfill": "0.1.2"
   }
 }

src/utils/signals.ts

@@ -9,6 +9,7 @@ export const w = new Signal.subtle.Watcher(() => {
     scheduleRevalidate();
 });
 
+export let signalsToUnwatch: Signal.Computed<any>[] = [];
 export function setResolveRender(value: () => void) {
   resolveRender = value;
 }
@@ -36,6 +37,7 @@ export async function syncDom() {
   w.getPending().forEach((cell) => {
     cell.get();
   });
+  w.unwatch(...signalsToUnwatch);
   w.watch();
   setIsRendering(false);
 }

src/utils/vm.ts

@@ -10,7 +10,7 @@ import {
 import { isFn } from './shared';
 import { Signal } from "signal-polyfill";
 
-import { w } from './signals';
+import { signalsToUnwatch, w } from './signals';
 type maybeDestructor = undefined | (() => void);
 type maybePromise = undefined | Promise<void>;
 
@@ -98,6 +98,6 @@ export function opcodeFor(tag: AnyCell, op: tagOp) {
   w.watch(computed);
   computed.get();
   return () => {
-    w.unwatch(computed);
+    signalsToUnwatch.push(computed);
   };
 }