Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: values in weak map #197

Closed
wants to merge 1 commit into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 23, 2025

No description provided.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 038cb41
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/679258783f659f00086d5c31
😎 Deploy Preview https://deploy-preview-197--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart force-pushed the experiment-store-values-in-weak-map branch from 444999c to 2554c68 Compare January 23, 2025 14:11
Copy link

github-actions bot commented Jan 23, 2025

duration phase no difference [-32ms to 80ms]
renderEnd phase no difference [-2ms to 1ms]
render1000Items1End phase no difference [-9ms to 2ms]
clearItems1End phase no difference [-1ms to 2ms]
render1000Items2End phase no difference [0ms to 1ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated regression +21ms [9ms to 33ms] OR +0.67% [0.3% to 1.06%]
clearManyItems1End phase no difference [-3ms to 2ms]
render5000Items2End phase no difference [-2ms to 30ms]
clearManyItems2End phase no difference [-6ms to 6ms]
render1000Items3End phase estimated regression +9ms [0ms to 16ms] OR +1.66% [0.08% to 2.88%]
append1000Items1End phase no difference [-24ms to 16ms]
append1000Items2End phase no difference [-13ms to 10ms]
updateEvery10thItem1End phase no difference [0ms to 16ms]
updateEvery10thItem2End phase no difference [-3ms to 2ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 1ms]
removeSecondRow1End phase no difference [-1ms to 1ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase no difference [-2ms to 2ms]
paint phase no difference [0ms to 0ms]

[15:39:57] Generating Benchmark Reports [started]
[15:40:05] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart force-pushed the experiment-store-values-in-weak-map branch from 2554c68 to 038cb41 Compare January 23, 2025 14:55
Copy link

Code Coverage Report

Coverage after merging experiment-store-values-in-weak-map into master

78.63%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts806, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.4483.3318, 27
tests
   utils.ts98.4794.44113, 114, 115
utils
   component.ts98.0352, 55, 89, 94, ...
   context.ts46, 54, 72, 79, ...
   dom-api.ts96.6726, 40, 41, 42, ...
   dom.ts98.0595.74972, 984, 998, 999, ...
   math-api.ts96.9721, 22
   reactive.ts94.5950, 64, 69, 70, ...
   runtime.ts16, 21
   shared.ts61, 67, 69, 93, ...
   svg-api.ts82.2227, 28, 29, 30, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts67.4424, 25, 26, 27, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts73.1276.9292, 93, 94, 95, ...
   list.ts94.9090.9189, 9, 90, 91, ...
utils/glimmer
   destroyable.ts12, 26, 36, 50, ...
utils/helpers
   and.ts77.784, 5, 6
   eq.ts3, 4
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts71.433, 4, 5
   or.ts4
utils/inspector
   ember-inspector.ts12.45096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts50.9186, 87, 98, 99, ...
   rehydration.ts153, 39, 42, 79, ...

@lifeart lifeart added the experiment Experimental PR's label Jan 28, 2025
@lifeart lifeart closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment Experimental PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant