-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lionel lig 5887 make arguments to masked pooling non optional #1776
Closed
liopeer
wants to merge
70
commits into
master
from
lionel-lig-5887-make-arguments-to-masked-pooling-non-optional
Closed
Lionel lig 5887 make arguments to masked pooling non optional #1776
liopeer
wants to merge
70
commits into
master
from
lionel-lig-5887-make-arguments-to-masked-pooling-non-optional
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: guarin <43336610+guarin@users.noreply.github.com>
Co-authored-by: guarin <43336610+guarin@users.noreply.github.com>
Co-authored-by: guarin <43336610+guarin@users.noreply.github.com>
…i/lightly into lionel-lig-5628-add-detconloss
…ooling-non-optional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
- Coverage 85.25% 85.24% -0.01%
==========================================
Files 163 163
Lines 6834 6832 -2
==========================================
- Hits 5826 5824 -2
Misses 1008 1008 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
num_cls
argument topool_masked
non-optionalnum_cls
Reason for the Change
num_cls
, better to make it explicit