Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lionel lig 5887 make arguments to masked pooling non optional #1776

Conversation

liopeer
Copy link
Contributor

@liopeer liopeer commented Jan 10, 2025

Changes

  • makes num_cls argument to pool_masked non-optional
  • removes tests for auto-inference of num_cls

Reason for the Change

  • bad heuristics in inference of num_cls, better to make it explicit
  • multiple calls with different masks could return tensors of differing shapes (impossible to stack/concatenate)

@liopeer liopeer closed this Jan 10, 2025
@liopeer liopeer deleted the lionel-lig-5887-make-arguments-to-masked-pooling-non-optional branch January 10, 2025 09:32
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (f6ad8c7) to head (b8f0335).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
- Coverage   85.25%   85.24%   -0.01%     
==========================================
  Files         163      163              
  Lines        6834     6832       -2     
==========================================
- Hits         5826     5824       -2     
  Misses       1008     1008              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant