Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lionel lig 5994: Update the BYOL examples #1794

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

liopeer
Copy link
Contributor

@liopeer liopeer commented Feb 4, 2025

Adds description to BYOL examples, following #1782
Screenshot 2025-02-04 at 10 01 44

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (061223a) to head (b2d41b7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1794   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         163      163           
  Lines        6833     6833           
=======================================
  Hits         5825     5825           
  Misses       1008     1008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions.

liopeer and others added 5 commits February 4, 2025 10:49
Co-authored-by: stegmuel <36367013+stegmuel@users.noreply.github.com>
Co-authored-by: stegmuel <36367013+stegmuel@users.noreply.github.com>
Co-authored-by: stegmuel <36367013+stegmuel@users.noreply.github.com>
Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Optional: update the screenshot.

@liopeer
Copy link
Contributor Author

liopeer commented Feb 4, 2025

final screenshot before merging:
Screenshot 2025-02-04 at 11 17 28

@liopeer liopeer merged commit 22464e3 into master Feb 4, 2025
14 checks passed
@liopeer liopeer deleted the lionel-lig-5994-update-the-byol-examples branch February 4, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants